Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amenity=bicycle_repair_station symbol (public 24/7 tools for fixing bikes) #1353

Closed
wants to merge 2 commits into from

Conversation

brycenesbitt
Copy link

An amenity=bicycle_repair_station is usually available 24/7,and hosts tools for repairs of bicycles. There are now over 500 mapped. Many people are not aware these stations even exist, thus the mapping.

The svg file is licence compatible.

@matkoniecz
Copy link
Contributor

Please, add before/after images.

@matkoniecz matkoniecz added this to the New features milestone Mar 4, 2015
@pnorman
Copy link
Collaborator

pnorman commented Mar 6, 2015

Does Mapnik even support all the stuff you're using in that SVG? I believe there's a way to export a sane SVG from Inkscape.

r="161"
cy="409"
cx="215"
style="fill:none;stroke:#000000;stroke-width:40px;stroke-opacity:1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had problems with stroke before in Mapnik

@pnorman
Copy link
Collaborator

pnorman commented Mar 6, 2015

Regardless of the technical issues with the SVG, I'm against adding amenity=bicycle_repair_station. I feel it's too specialized and is similar to some other bicycle-specific features we've decided not to render (#591).

I'd like to see the example images covering the proposed rendering in a variety of settings.

@matkoniecz
Copy link
Contributor

is similar to some other bicycle-specific features we've decided not to render (#591).

In case of #591 I think that current situation is that there is no consensus for small ones, but gigantic ones should be somehow rendered.

In this case I am unsure - what after correcting for my positive bias toward anything cycling-related may be counted as being against rendering amenity=bicycle_repair_station.

@matthijsmelissen
Copy link
Collaborator

I see no harm in rendering this, but only from high zoom levels to avoid clutter (z18 or z19). I think z17 is too early for a general purpose map.

@nebulon42
Copy link
Contributor

@brycenesbitt re consistency: Here is my suggestion for bike repair that is consistent with bike rental (which is already in master) repair-bicycle-18 nebulon42/osmic/repair-bicycle-18.svg

Here is a version without halo (preferred by maintainers): https://gist.githubusercontent.com/nebulon42/bcae5a3d535ff862a99a/raw/6dda54bc284e36fb430dd6e130ed6a2b668da92d/repair-bicycle-16.svg

@matthijsmelissen
Copy link
Collaborator

I think 500 items is still too little for it too deserve its own icon. Maybe in the future! Thanks anyway @brycenesbitt!

@brycenesbitt
Copy link
Author

This is a worldwide feature, growing, with the capability of drawing new mappers to the project. A fraction of the existing stations are mapped, but the feature will still be far more rare than toilets or bike parking:
selection_189

Conflicts:
	amenity-points.mss
@kocio-pl
Copy link
Collaborator

Now the number of uses is much higher (2800), the new icon has been proposed in a duplicate ticket, but we already have it in Osmic:

https://github.com/gmgeo/osmic/blob/master/shop/repair-bicycle-14.svg

@kocio-pl kocio-pl reopened this Feb 12, 2018
@kocio-pl
Copy link
Collaborator

Oh, sorry - it's the old PR, not an issue...

@kocio-pl kocio-pl closed this Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants