Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rendering for bicycle_parking #1361

Closed
wants to merge 2 commits into from
Closed

Add rendering for bicycle_parking #1361

wants to merge 2 commits into from

Conversation

matthijsmelissen
Copy link
Collaborator

  • Add bicycle_parking icon from z18 or (for areas) 750 pixels, whichever is
    earlier.
  • Add yellow background for bicycle_parking (like regular parking).

Thanks to @nebulon42 for the icon.

This resolves #591 and part of #108.

@pnorman
Copy link
Collaborator

pnorman commented Mar 10, 2015

assigning to @gravitystorm for him to decide if we want to render bicycle_parking

@matkoniecz
Copy link
Contributor

@math1985 This PR adds only .svg file without any logic to render it.

@matkoniecz
Copy link
Contributor

Also, why it is 18px sized icon? Is it icon with halo like ones from rejected #1341?

@matthijsmelissen
Add rendering for bicycle_parking
929dce9 
* Add bicycle_parking icon from z18 or (for areas) 750 pixels, whichever is
  earlier.
* Add yellow background for bicycle_parking (like regular parking).

Thanks to @nebulon42 for the icon.

This resolves gravitystorm#591 and part of gravitystorm#108.
@matthijsmelissen
Copy link
Collaborator Author

Pushed missing files.

The icon was proposed at 18px by @nebulon42. I doubt it works on 16px.

@HolgerJeromin
Copy link
Contributor

ihmo the name of the feature is not rendered. Is this intentional?

@matthijsmelissen
Copy link
Collaborator Author

ihmo the name of the feature is not rendered. Is this intentional?

Yes, it's not rendered for car parkings either.

@HolgerJeromin
Copy link
Contributor

Yes, it is: http://www.openstreetmap.org/way/8089509

@matthijsmelissen
Copy link
Collaborator Author

You're right, I added the label now.

@matkoniecz
Copy link
Contributor

I think that also transparency for private ones should be added (like for amenity=parking).

@matkoniecz matkoniecz mentioned this pull request Mar 11, 2015
Merged
@nebulon42
Copy link
Contributor

Before gmgeo/osmic@135010e all icons are versions without halos. If you don't want them just use those.

@matthijsmelissen
Copy link
Collaborator Author

Closed in favour of #1364.

@matthijsmelissen matthijsmelissen deleted the bicycle-parking branch March 16, 2015 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gravitystorm gravitystorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rendering for amenity=bicycle_parking
6 participants
@matthijsmelissen @pnorman @matkoniecz @HolgerJeromin @nebulon42 @gravitystorm