Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift minimal zoom levels for villages and hamlets. #1597

Closed
wants to merge 1 commit into from

Conversation

jekhor
Copy link

@jekhor jekhor commented May 30, 2015

In continue of discussiion in the #472

Shift minimal visible zoom level for village to 11 and to 12 for
hamlets. Set minimal text distance to 30 for villages names at zoom 11.

Switzerland, z11:
sw-z11
Switzerland, z12:
sw-z12
Switzerland, z13:
sw-z13

Belarus, z11:
bel-z11
Belarus, z12:
bel-z12
Belarus, z13:
bel-z13

At current setup, villages are shown at zoom levels >= 12 and hamlets at
zoom levels >= 14. In many countries the map seems 'uninhabited' with such
settings and this make it unusable for trip planning.

Shift minimal visible zoom level for village to 11 and to 12 for
hamlets. Set minimal text distance to 30 for villages names at zoom 11.

Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
@imagico
Copy link
Collaborator

imagico commented May 30, 2015

I don't think this is going to work well - especially shifting the threshold for hamlet (and locality/neighbourhood/isolated_dwelling/farm) from 15 to 12. Keep in mind that these labels will prevent most other labels from showing up.

And whenever you try to show more labels than fit at the current zoom level the choice which labels are shown and which not gets hugely arbitrary unless you have a way to sort them by priority. At z=12 you will in many areas probably not be able to show more than 10-20 percent of the hamlets.

The problem you are trying to address, i.e. that labeling is much too sparse in less densely populated areas, esp. at higher latitudes is a serious one but the solution is not to universally show more labels even in densely populated regions. See also #1461.

Technically you will need to modify project.yaml and generate project.mml using the yaml2mml.py scripts.

@kocio-pl
Copy link
Collaborator

I guess zoom level tuning (which zoom level should some kind of tagging start being visible) is too general tool, which is not able to embrace whole world's diversity. We should start using local density limits more, as described in #1560 (comment), for all kind of points, including icons and names.

In practice that would mean we make the zoom levels suitable for low density places and fine tune the limits on the most dense places, so we have something working universally and limited (automatically!) only when there's too many items.

How about that?

BTW - the real command line for MML file generation should look like (issued from the directory with project.* files):
./scripts/yaml2mml.py < project.yaml > project.mml

@matkoniecz
Copy link
Contributor

See https://travis-ci.org/gravitystorm/openstreetmap-carto/builds/64689058

project.yaml and project.mml are not in sync!

You should only modify project.yaml, not project.mml and run scripts/yaml2mml.py before committing.

Read https://github.com/gravitystorm/openstreetmap-carto/blob/master/CONTRIBUTING.md#editing-layers for further information.

@matkoniecz
Copy link
Contributor

Closing for now, since project.yaml and project.mml are not in sync (@imagico mentioned it on 30 May) and there is no response to other points raised by @imagico.

@matkoniecz matkoniecz closed this Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants