-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meadow/grassland and orchard/vineyard color unification #1655
Conversation
* unify landuse=meadow and natural=grassland * unify base color of landuse=orchard and landuse=vineyard * new fine grained pattern for landuse=vineyard * patterns for orchard/vineyard start at z=14 instead of z=13 * move landuse=conservation to nature reserve boundaries
Very good idea. |
I think it would be better as separate PRs, at least "move landuse=conservation to nature reserve boundaries" should be separate. Maybe also "meadow/grassland" and "orchard/vineyard color unification" would be better as separate. It simplifies testing, discussion and code review. |
Completely unrecognisable for me. There is no standard pattern for vineyards for maps made in Poland as this feature is extremely rare here. |
@imagico - is this test place is maybe an area close to you where you may perform local survey? In that case - can you look at https://www.openstreetmap.org/note/396185 https://www.openstreetmap.org/note/396187 https://www.openstreetmap.org/note/396188 https://www.openstreetmap.org/note/396189 |
@matkoniecz BTW: there is a lengthy discussion going on tagging list about rural highways - a proposition was given to tag them as highway=service+service=rural when they are not really highway=track. I don't know however if this is the case. |
Actually i did this together to be able to test how these colors fit together. Changing colors one at a time is difficult since there are always interdependencies. You'd start changing the orchard color and then notice you'd better change it again to better accommodate the change in grass color. I can take the change of landuse=conservation out here if there are doubts about it. Just wanted to make sure that the color change is not meant to apply to landuse=conservation. Regarding the pattern - this type is also used on french maps, on Italian maps i have seen a somewhat similar 'L' shaped symbology - see page 6 here, the pattern also appears to be at least somewhat intuitive considering the appearance of current industrialized vineyards - at least not worse than the orchard pattern. Spanish maps use a different symbol which however seems much less intuitive. And that together covers more than two thirds of the world wine production... |
OK, I hoped that at least landuse=conservation may be tested independently. |
To make it clear - I am not thinking that lack of recognition for this symbol in Poland as a valid reason for rejecting this change (Poland has about 50 mapped vineyards). |
Consider the opinion of a French man if you will : I don't recognize those patterns either. I think the original pattern (3 raisins on the vine) is much more recognizable for the vineyards. The orchard pattern isn't great, but I'm not sure what would be better. Perhaps an apple is the most universally-recognizable fruit ? As for the color changes, they look good to me. |
I realize this is a question on how much abstraction is desirable and how abstraction is made. The grape symbol uses fairly little abstraction in design but is quite abstract in the way it connects the landuse to the product produced (a bit like symbolizing forest with piles of logs). Someone unfamiliar with the product, visiting the vineyard only during winter, will not be able to make this connection. This makes the pattern unique in this style at the moment, all other patterns use symbols that are abstractions of the appearance of the area in question itself. One problem of this is it cannot be made any smaller than it is without being unrecognizable. This means this needs to be a very coarse pattern which essentially makes it unsuitable for the lower zoom levels. I would be open to a less abstract visualization of the appearance of a vineyard but this seems difficult without being misleading. My current suggestion might be unclear but i don't think it is misleading in the way it positively creates a wrong association. Does anyone have examples for use of the grapes symbology in patterns in non-OSM maps? |
One solution is to first do the colour changes in a spreadsheet, calculating colour differences. This can cut back the number of tests you have to do on the map, and let you be more precise in what to check on each iteration. |
It seems there is agreement about the colors but some objections concerning the vineyard pattern. I can change this back to the old one but since all objections so far have been based on a subjective difficulty to recognize the meaning of the pattern i am not really sure this is sufficient basis to decide this is really overall the preferable solution. So again my primary reasons for using a different pattern summarized:
Further input (arguing either for or against the pattern change or suggesting a third option) would be good. |
The new pattern looks okay to me, but i haven't had a chance to load it up in Kosmtik. |
Kosmtik bug? |
E_NOTIME |
Huhu ok ;) |
And I am not considering my doubts as good reason to reject/change PR - but I will not merge it. Maybe @math1985 or @gravitystorm may try looking at this PR? |
I haven't had time to look at it yet. |
I think both having a more pictographic and a more simplified representation have their merits. I find it hard to pick between the two. @gravitystorm What do you think? |
meadow/grassland and orchard/vineyard color unification
I'm happy with the abstract symbols for pattern fills. I'm slightly biased since (as @imagico links above) I use similar symbols in my own maps. But more importantly, pattern fills can repeat the symbol many hundreds of times, so they should be as simple as possible to reduce visual noise - it's more likely that an abstract symbol will be visually simpler than a (often complex) icon. |
@imagico - are you planning to make & test new PR for
? |
Opened a new issue for that: #1826 |
Attempting to reduce clutter and variety of green tones:
move landuse=conservation to nature reserve boundaries (long overdue IMO but not really tested on real world objects).Examples (from around here):