Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding amenity=veterinary icon #1656

Closed
wants to merge 1 commit into from

Conversation

kocio-pl
Copy link
Collaborator

Resolves #1649.

veterinary-inwalidow

@HolgerJeromin
Copy link
Contributor

The idea on reusing the icon is good, both colors are much too similar for me.

@kocio-pl
Copy link
Collaborator Author

Any other ideas then?

@HolgerJeromin
Copy link
Contributor

moving healthcolor more to red? duck :)

@daganzdaanda
Copy link

Agree, the colour difference alone does not work. I tried to put the cross in the paw:
vet16a
https://gist.github.com/daganzdaanda/ded21489b7056d2b7609
It's not great yet, but it could be possible.

@kocio-pl
Copy link
Collaborator Author

The second icon (cross and a solid paw) is what I was also considering, but I don't know when I will have the time to try. Could you make 14px versions of the icons to test if they will be readable at all?

@daganzdaanda
Copy link

vet16a16
Not very great, but I did not try to improve the pixel-alignment.

@dieterdreist
Copy link

sent from a phone

Am 15.07.2015 um 16:02 schrieb daganzdaanda notifications@github.com:

It's not great yet, but it could be possible.

last one is great

@kocio-pl
Copy link
Collaborator Author

I don't think so - we should retain as much resemblance between full version icon and smaller versions (like bicycle parking or car service) as it's possible. This case is hard because original paw is too small for a cross and we don't see the upper border (which makes cross look less like a cross), but even then there it should be at least more symmetrical, like in the original.

@nebulon42
Copy link
Contributor

@daganzdaanda The circle one look promising (second row, first). Maybe try without white colour, but with subtracted shape as this will likely look quite different (less contrast). Maybe a bit more symmetry and a bit less blur. But great progress here, I have tried myself several times but did not find something suitable.

@kocio-pl While I would normally agree with your concerns re resemblance and symmetry I think for this hard case we should surrender these to the possibilities at hand.

@kocio-pl
Copy link
Collaborator Author

@nebulon42 Symmetry is important I think, because the last one (in 14 px version) brought to my mind human foot clinic, while dog's paw can look nearly exactly as in your design.

BTW: what do you think about the second icon?

@nebulon42
Copy link
Contributor

The second might work too, but is a bit noisy IMO.

@rmikke
Copy link

rmikke commented Jul 16, 2015

Both icons in upper row are OK. The color scheme change is OK.
All the designs with cross inside a paw will be unreadable, IMHO, just because on map it will be not so easy to guess it's a paw...

@daganzdaanda
Copy link

https://gist.github.com/daganzdaanda/74ca85f6f4dc5fe2ba9b
vet16b32
vet16b16
The leftmost icons are unchanged from the previous try, except for subtracting the negative cross.

@kocio-pl
Copy link
Collaborator Author

I still like 1) the most - 2) is less readable at 14 px (the spaces are too small, so the details are less distinct). 3), 4) and 5) all look alike for me at 14 px and I like them less, however they're good too. I will try to test both soon to show them on real map.

@daganzdaanda
Copy link

@nebulon42 has added an icon to osmic gmgeo/osmic@54eb961
https://github.com/nebulon42/osmic/blob/54eb9611aaf9fc3af70bf8d834a92b69d18e622e/health/veterinary-14.svg
It looks better than my version, because the toes have more space.
The main question is, whether the circle-paw is still recognized as a paw and therefore the icon as a vet icon.

@kocio-pl
Copy link
Collaborator Author

The same place (you can compare it with the pet shop and pharmacy here):

this is how @nebulon42 version looks like:
veterinary-circle

and this is @daganzdaanda version (with small fix to be better aligned in 14px square, which adds a bit more space between a paw and a cross):
veterinary-small

For me both are good - what do you think?

@matkoniecz
Copy link
Contributor

This branch has conflicts that must be resolved

@matkoniecz
Copy link
Contributor

I prefer version by @nebulon42 Icon by @daganzdaanda seems to be a two separate objects.

Random person was unable to recognise both icons as veterinary (though he has no pet, so it was for him far less likely to consider this possibility) - but it was recognised as healthcare-related thanks to the cross. He also claims that both icons are not resembling paw.

@kocio-pl
Copy link
Collaborator Author

I will fix it and rebase once we've decided which one to use.

@nebulon42
Copy link
Contributor

Actually are both versions by @daganzdaanda, I merely made some parts symmetrical.

@kocio-pl
Copy link
Collaborator Author

Random mapper told me that both are very nice and recognizable (no pet owner too =} ), but the second one is more clear. However I like first more, because field test proves that second may be too small for some users and its elements are really detached.

I have also some other ideas, like dogs/horse head with cross inside or half the head (or paw) with syringe. Would anybody try to test it?

@kocio-pl
Copy link
Collaborator Author

Another design idea:
3) veterinary-14-cat-1

@ximex
Copy link

ximex commented Jul 23, 2015

i like the first one. (the one with the + on the top left)

@kocio-pl
Copy link
Collaborator Author

Icon 1) is similar but more readable than in german style. Still I like icon 2) more, because it's more coherent and its parts are not so tiny.

@matthijsmelissen
Copy link
Collaborator

Current symbol looks fine to me.

@kocio-pl
Copy link
Collaborator Author

AFAIK amenity=veterinary has no symbol yet... 😄 Which one are you referring to? Maybe you've just thought about shop=pet?

@matthijsmelissen
Copy link
Collaborator

I meant the currently proposed symbol. The PR was closed because it was merged :).

@kocio-pl kocio-pl deleted the veterinary-icon branch August 16, 2015 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants