Added rendering of tag tourism=wilderness_hut #2140
Conversation
Revised min zoom visibility for some elements
Revert "Revised min zoom visibility for some elements"
…menity=shelter. Notice that this drop shall be consistent with the other push related to zooms, where alpine_hut symbol (the main one) is shown at zoom>=13. To summarize, the following different kind of huts have specific symbols now: amenity=shelter, shelter_type=basic_hut (zoom>=13) amenity=shelter (only shown at zoom >=16) tourism=alpine_hut (zoom>=13) tourism=wilderness_hut (not modified within this drop)
|
Added rendering of tag tourism=wilderness_hut Notice that this drop shall be consistent with the other push related to zooms, where alpine_hut symbol (the main one) is shown at zoom>=13. To summarize, the following different kind of huts have specific symbols now: amenity=shelter, shelter_type=basic_hut (zoom>=13)
|
| @@ -1666,11 +1666,12 @@ Layer: | |||
| denomination, | |||
| "generator:source", | |||
| power_source, | |||
| tags->'shelter_type'::text AS shelter_type, | |||
There was a problem hiding this comment.
We do not have hstore available so this does not work.
|
2.1k usages is towards the low end, but on the other hand this is a feature which will normally be encountered in remote areas. There are a lot of commits in this PR, could you rebase them into one? |
Could you please better explain?
I expected it was available, it looks already present in openstreetmap-carto.style, but probably I misunderstood a comment by @HolgerJeromin. |
If i am not wrong squashing commits is now available in the merge interface. |
It is not enabled by default. See #2103 |
2.1k is above "low usage, therefore rendering support is certainly a bad idea", but still it is not popular tag. So it is slight nudge toward not rendering it. "on the other hand this is a feature which will normally be encountered in remote areas." - so it is unlikely to compete with already rendered icons, so it slight nudge toward rendering it. |
|
Since alpine_hut and shelter use a common icon design it is not a good idea to have a different design for this which is logically between the other two. Apart from that the idea itself seems fine. |
SVGs cleaned Icon usage: alpine_hut: symbols/alpinehut.p.16.png wilderness_hut: symbols/wilderness_hut.svg generic shelter: symbols/shelter-14.svg amenity=shelter with shelter_type=basic_hut: symbols/basic_hut.svg
Please, suggest the correct git commands, thanks. I usually perform this: Meanwhile I revised the code that now should reflect feedbacks by @pnorman:
Icon usage:
@matkoniecz thanks for explanation. Just in Italy we now have 774 huts which are managed by CAI (Italian alpine club; there are many more active huts in Italy so). Let's suppose that there might be at least two wilderness huts per alpine hut. We could imagine that the current figure of 1452 nodes + 688 ways cannot reflect the entire planet (notice also that they should be represented as building, not just nodes). Once again, unfortunately geographical information related to scarcely populated areas in OSM has currently no quality at all. Could its cause be the same mentioned in #2138? (That is, these kind of tags are not rendered). In my opinion with OSM people are currently more keen to add urban and suburban data ("OSM=open street") and data that can be rendered ("OSM=open map"). To try to fill this gap (let's say, OSM to become open planet data), IMHO it should be appropriate to enable many more elements on the OSM map. Also, as @imagico was mentioning in #2138 (and @drgweber in #1148), we would need an effective communication program, including well defined style guides to drive mappers on “remote areas”, which are currently green field for them and where business digital maps are slow to enter (market failure zones). |
See for example http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html Note that "A word of caution: Only do this on commits that haven’t been pushed an external repository." does not apply here (as it may safely assumed that nobody pulled from this branch and based their work on this changes). |
…osed. **Added rendering of tag tourism=wilderness_hut** Added specific symbols for basic_hut and wilderness_hut vs. generic amenity=shelter. Notice that this drop shall be consistent with the other push related to zooms, where alpine_hut symbol (the main one) is shown at zoom>=13. To summarize, the following different kind of huts have specific symbols now: - amenity=shelter, shelter_type=basic_hut (zoom>=13) - amenity=shelter (only shown at zoom >=16) - tourism=alpine_hut (not modified within this drop) - tourism=wilderness_hut (zoom>=13) alpine_hut: symbols/alpinehut.p.16.png wilderness_hut: symbols/wilderness_hut.svg generic shelter: symbols/shelter-14.svg amenity=shelter with shelter_type=basic_hut: symbols/basic_hut.svg
|
This PR will be closed as superseded by #2145 |
No description provided.