Adding rendering for amenity=ferry_terminal

[kocio-pl]

Related to #2094.
Resolves #869.

Looks like airport area rendering is rather for large area and ferry terminal is more like a railway station, so I took it. Labels are however the same like in the airport, but rendered later.

I also made some cleaning in color variables.

Examples:

Warsaw, z15 (nodes only, compared to some other labels)

Victoria (nodes and typical area)
z14 (not rendered)

z15

z16

z17

z18

z19

[kocio-pl]

Another possibility - labels the same as the bus stop - doesn't work for me:

BTW: are there really so large railway stations which should be rendered from z10? If not, maybe we can adjust SQL to optimize query for some higher zoom levels?

[pnorman]

Can review when I get home.

[kocio-pl]

As the station color seems to be designed for buildings, it can be made lighter (here or in separate PR). We could also go with airport area color, but it's too pale for this usage IMO:

z17

z18

z19

[matthijsmelissen]

@kocio-pl Could you rebase this? I have the impression something went wrong, looking at the diff (or I'm misunderstanding the diff algorithm again).

[kocio-pl]

After some time away from this PR I've changed my mind and like to use the lighter version for a background, because current station color seems to be designed with station building in mind, not for the area (merging #2443 will have some implications there).

I don't need to find it from a distance (ferry lines are good hint), it's enough to see its shape to understand how the space is used. Also using the same color for airport, ferry and station area (and possibly other transportation areas) would be more consistent.

I will fix the code soon.

[kocio-pl]

The code is updated and ready to be merged.

General notes:

• The area is now rendered as the aerodrome (not as the railway station), the rest remains the same
• There was variable sections cleaning done

[nebulon42]

I think it is not a good thing to mix cleanups with changes. It makes diffs harder to read (you could still leave it in this PR but move it to a separate commit). Since there were some changes of design over the course of the PR I don't get the changes at first glance. Could you please show a proper before after comparison?

[pnorman]

I think it's more worthwile to render an icon for a ferry terminal than a fill. These are features that people are often looking for, and an icon is better for that.

[kocio-pl]

The fill and the icon play a different role, just like in the airport: icon make it easier to find on the big picture, while the fill is important when zoomed in to know which roads and buildings belong here. This is related to #2094.

Unfortunately we have no such icon available, because none of my propositions was approved by the community (#1673), but if we have one, I would like to show it too.

[kocio-pl]

Code is cleaned now and here are basic before/after renderings (I won't make it extensive, because most of previous are correct except those with red background):

Warsaw, z15
Before:

After:

Victoria, z18
Before:

After:

[kocio-pl]

Code is updated now and ready to be merged.

[matthijsmelissen]

I agree this feature would need an icon for it to be useful (sorry for slow review).

[matthijsmelissen]

Requesting changes.

[kocio-pl]

Any hints about the icon design? Maybe the discussion in the #1673 could be useful here.

I think the icon should be visible only to some zoom level (like the airport, but later, since typical ferry terminal is smaller). It wouldn't be visible on z18 then, so the rendering above would be the same.

[kocio-pl]

This is how original icon works in reality (but it's black here):
https://maps.wikimedia.org/#18/52.23707/21.03863
https://maps.wikimedia.org/#18/48.42213/-123.37224

I also think we could try with something more symbolic and easier to recognize, like the anchor:

1. https://openclipart.org/detail/10145/aussersihl-coat-of-arms
   

2. https://openclipart.org/detail/190960/anchor
   

3. https://openclipart.org/detail/18387/simple-anchor
   

What do you think?

[matthijsmelissen]

To me, the anchor doesn't really remind me of a ferry terminal. Not sure what others think.

[kocio-pl]

I would be happy to at least have some hint what could work for the others, since my ideas were not accepted till now and I ran out of them. However first anchor is still good for me.

[dieterdreist]

2017-03-22 13:47 GMT+01:00 kocio-pl <notifications@github.com>:

I would be happy to at least have some hint what could work for the others, since my ideas was not accepted till now and I ran out of them. However first anchor is still good for me.

IMHO it could be a car on a ship or inside a ship. An anchor is far too generic.

[matthijsmelissen]

Not all ferries carry cars. Maybe a generic icon of a ship?

[dieterdreist]

2017-03-22 15:24 GMT+01:00 Matthijs Melissen <notifications@github.com>:

Not all ferries carry cars. Maybe a generic icon of a ship?

not all ships are ferries ;-) After a quick look I think that current ferry tagging is immature, it won't allow us to distinguish between huge ferry terminals and small passenger ferry stops on a river like here: http://www.openstreetmap.org/node/1051302891 Also the term "terminal" is indicating an endpoint, for intermediate stops it isn't right. there's also a new proposal for these kind of features (currently not used for this style): https://wiki.openstreetmap.org/wiki/Proposed_features/Seaway

[pnorman]

As this has cartography changes, this PR is currently held up by the feature freeze until 4.0.0 has been released.

[matthijsmelissen]

@kocio-pl What is the status of this PR?

[kocio-pl]

I took some time to let the idea establish a bit in my head. Now I plan to eventually update it with 1. anchor icon, because:

• it's generic enough and much easier to recognize than our previous attempts to depict ships,
• having icon here conforms our style for transport amenities (blue icons for bus/tram stops or the airports) and having consistent system is enough to give user a hint what is the context of the anchor (transport),
• it's probably not going to be used for any other water-related feature (like marina or port).

[kocio-pl]

@dieterdreist I think that current tagging is just generic, I wouldn't call it immature - this problem applies to many old features (like healthcare amenities or public transport). However your seaway=* proposition looks quite interesting to me, but it's not yet practically used (6 uses now) nor even proposed for discussion (it's still a draft), so we can re-examine it later.

[kocio-pl]

Current rendering (with icon):

Warsaw, z15
Before

After

Sidney (Canada)
z15
Before

After

z18
Before

After

[kocio-pl]

Are there any other issues not discussed before?

[pnorman]

It's worth checking an inner harbor dense with small ferry terminals. http://www.openstreetmap.org/#map=15/49.2726/-123.1264 has some

[kocio-pl]

Vancouver, z15 (click to see unscaled images):

[kocio-pl]

I feel this code is ready to be merged, but I don't know how long should I wait and what for, because it's quite old, but formal requirement (using icon) is fulfilled for just a few days. On the other hand nobody was opposing. Our decision rules are hard to apply to long and evolving solutions.

[vss-devel]

I've noticed that Mapnik started rendering amenity=ferry_terminal with an anchor symbol .

At nautical maps a similar symbol denotes an anchorage, so this usage of an anchor for the amenity=ferry_terminal is quite misleading.

[kocio-pl]

It's not a nautical map and none of the ship icon was clear enough for osm-carto community (even if they are used on some other styles). I also noticed using the anchor symbol in some other general map, but unfortunately I don't remember which one.

[imagico]

@Vadp - you should best open a new issue for this.

Not only in nautical maps by the way, see for example chapter 2, symbol 226 in http://www.lib.berkeley.edu/EART/pdf/soviet.pdf - likewise for some pre-digital German TK100/TK200 (don't have a digitized sample at the moment).

[dieterdreist]

I agree an anchor is not a good symbol for a ferry

[vss-devel]

I agree an anchor is not a good symbol for a ferry

@dieterdreist I've opened #2785 for this issue.