Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert white color for unimportant roads #2769

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

kocio-pl
Copy link
Collaborator

Resolves #2731.

Reverts unimportant roads color from white to @residential-casing color (as in v4.1.0).

Before revert:
bzq1gjxn
After revert:
g crgmz5

@meased
Copy link
Contributor

meased commented Aug 22, 2017

I prefer the white.

@matthijsmelissen
Copy link
Collaborator

@kocio-pl
Copy link
Collaborator Author

@meased I think there will be lot of discussions with other changes, so we can change this color later.

@math1985 Do you mean this block only (till https://github.com/gravitystorm/openstreetmap-carto/pull/2654/files#diff-f61408bc1ffb6636dbaf2bf9e38a4177L1068) or something more? Altering road code is quite a challenge nowadays.

@matthijsmelissen
Copy link
Collaborator

I think so, but make sure to test it anyway. Road width might need changing too.

@kocio-pl kocio-pl force-pushed the unimportant-roads-white branch from e3a8e42 to bafcd49 Compare August 22, 2017 21:55
@kocio-pl
Copy link
Collaborator Author

I'm not sure how to test it - with reverted ::halo section it works at least (code compiles and roads don't look like broken or missing).

I'm not even sure if anything more than color change was the problem to solve.

roads.mss Outdated
@@ -1048,30 +1048,32 @@ tertiary is rendered from z10 and is not included in osm_planet_roads. */
.tunnels-fill[zoom >= 10] {

::halo {
[feature = 'highway_motorway'][link != 'yes'][zoom >= 8][zoom < 12],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block should be kept (it is the halo for low-zoom roads). So we need both blocks now.

@kocio-pl kocio-pl force-pushed the unimportant-roads-white branch from bafcd49 to edc04e9 Compare August 23, 2017 09:34
@kocio-pl kocio-pl force-pushed the unimportant-roads-white branch from edc04e9 to 6815387 Compare August 23, 2017 09:43
@kocio-pl
Copy link
Collaborator Author

Done and it works, anything else that should be done here?

Copy link
Collaborator

@matthijsmelissen matthijsmelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kocio-pl kocio-pl mentioned this pull request Aug 23, 2017
@kocio-pl kocio-pl merged commit 9dccaa0 into gravitystorm:master Aug 24, 2017
@kocio-pl kocio-pl deleted the unimportant-roads-white branch August 24, 2017 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants