Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for slipway ways #2825

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Conversation

kocio-pl
Copy link
Collaborator

Resolves #484.

I'm not 100% sure about rendering names for ways, it's safer to skip it, since it's not clear if name label belongs to a slipway or a highway.

nhswhgef

@kocio-pl
Copy link
Collaborator Author

Are there any other linear amenities which should be shown on osm-carto?

@daganzdaanda
Copy link

Is this the same as highway=service? Maybe use the narrower styling like in service=parking_aisle? Slipways are normally not very long, and should not look too important IMHO.

Are there any other linear amenities which should be shown on osm-carto?

#1890 is about benches

@kocio-pl
Copy link
Collaborator Author

Thanks for both suggestions! However our road code is spaghetti-esque and I'm still not able to find out where should I add another type of service road... Could someone help me find where it's selected?

@kocio-pl
Copy link
Collaborator Author

OK, it works, but it's better if someone would check the SQL for casing and filling:

06jc vrz

@kocio-pl
Copy link
Collaborator Author

#1890 is about benches

I can think also about bus stops and I even think I saw it lately among other osm-carto issues, but forgot where it was mentioned.

@sommerluk
Copy link
Collaborator

I suppose that slipways have no own z_order value, and this could be a problem when sorting?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 14, 2017

I don't know, but it's hard for me to imagine that such specialized service road is crossing with other road on a different level.

@kocio-pl
Copy link
Collaborator Author

For me it's safe to be merged. Any comments or reviews?

@pnorman
Copy link
Collaborator

pnorman commented Oct 2, 2017

I don't know, but it's hard for me to imagine that such specialized service road is crossing with other road on a different level.

z_order isn't about different layers, it's within the same layer.

Are we requiring highway=service to render the white line?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Oct 2, 2017

I meant physical levels, not our internal level/layer.

For me this is a special service road (which ends up in water), but still just a service road, so I expect no rendering changes. Do you have some other suggestion?

@kocio-pl
Copy link
Collaborator Author

@pnorman Do you still have some questions about this? I would merge it soon.

@kocio-pl kocio-pl merged commit 80f5caf into gravitystorm:master Oct 13, 2017
@kocio-pl kocio-pl deleted the slipway branch October 13, 2017 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants