Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide tiny zoos and theme parks #2835

Merged

Conversation

matthijsmelissen
Copy link
Collaborator

@matthijsmelissen matthijsmelissen commented Sep 14, 2017

This starts showing zoos and theme parks from one zoomlevel before
they are large enough to get a name.

Example of theme parks of the size that will disappear now:

screen shot 2017-09-15 at 00 50 52

screen shot 2017-09-15 at 00 51 22

This starts showing zoos and theme parks from one zoomlevel before
they are large enough to get a name.
Copy link
Collaborator

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm undecided on this. Using a different threshold for rendering an area vs a label was intentional, but I'm not especially tied to it.

@matthijsmelissen
Copy link
Collaborator Author

The different treshold remains: the area is rendered one zoomlevel earpier.

@kocio-pl
Copy link
Collaborator

The different treshold remains: the area is rendered one zoomlevel earpier.

Does it? The code is just more strict on z10-16 and relaxed on z17+, but it was z10 before and you didn't switch to z9 instead. Did I understand you right?

@matthijsmelissen
Copy link
Collaborator Author

I mean that on zoom leveps z10-16, if you zoom in the area will appear one zoom level before the text appears.

@matthijsmelissen matthijsmelissen merged commit 72f6c8d into gravitystorm:master Sep 17, 2017
@matthijsmelissen
Copy link
Collaborator Author

Thanks for quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants