Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show island and islet labels earlier #2890

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

kocio-pl
Copy link
Collaborator

Resolves #1448.

Island names are currently rendered on z7+, but they should be rendered on z4+ (as early as possible, but not compete with country labels on z3) and islets also 3 zoom levels earlier.

@rrzefox: Could you test this patch on your server?

Nunavut (Canada) example

z4
Before
screenshot-2017-10-14 openstreetmap carto kosmtik
After
screenshot-2017-10-14 openstreetmap carto kosmtik 1

@sommerluk
Copy link
Collaborator

Looks good to me. That includes the change for islet. Islet names only showed up only on high zoom levels, because of the 1-km²-threshold in the wiki documentation, but the chosen zoom level (14) did only work well on low latitude. For high latitude like http://www.openstreetmap.org/way/27923209#map=13/83.6622/-30.6165 clearly zoom level 11 is a better threshold.

@kocio-pl
Copy link
Collaborator Author

Rendering the planet with just the island names. This should help us find all the missing tagging - for example Spitsbergen should be fixed now (the planet data are older), but Sumatra exist only as an islet in Dubai and we lack New Guinea and Greenland for sure.

The list to check:
https://en.wikipedia.org/wiki/List_of_islands_by_area#Islands

z4
island4-gimp

z5
island5-gimp

z6
island6-gimp

@rrzefox
Copy link

rrzefox commented Oct 18, 2017

@rrzefox: Could you test this patch on your server?

It's been deployed. Comparison as usual on http://bl.ocks.org/math1985/raw/af7a602c222dbf1ff1a2c0d84ed755b7/#5.00/72.344/-97.588
Z0-9 rerendered, 10-14 still pending. all relevant zoom levels should have been rerendered by now (2017-10-20)

@kocio-pl kocio-pl merged commit 24f6436 into gravitystorm:master Oct 20, 2017
@kocio-pl kocio-pl deleted the islands-low-zoom branch October 20, 2017 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants