Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing tourism=picnic_site icon colour to green #2991

Merged
merged 1 commit into from
Jan 21, 2018

Conversation

kocio-pl
Copy link
Collaborator

Resolves #2915.

Example place with both tourism=picnic_site and leisure=picnic_table:

Before
n 6jqh3v

After
fkf1l1zq

@kocio-pl
Copy link
Collaborator Author

Any reviews or comments?

@turnsole80
Copy link

This is a good change.

@polarbearing
Copy link
Contributor

polarbearing commented Dec 31, 2017

Isn't tourism brown and leisure green? So, should the colours assigned vice versa?

@kocio-pl
Copy link
Collaborator Author

Thanks, that's a good point! I think both keys are misleading in this case: picnic table is like other general amenities, especially bench, since it's rather about a rest than physical activity, while picnic site is also closer to recreation area (I would say it's really just a subtype of such area).

@kocio-pl kocio-pl merged commit 4f0d67f into gravitystorm:master Jan 21, 2018
@kocio-pl kocio-pl deleted the picnic_site_green branch January 21, 2018 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants