Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making gardens to use grass color with plant nursery pattern #3096

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Mar 1, 2018

Resolves #3022.

Green areas redesign (#2964) didn't work too well for gardens. It seems that garden is a very wide concept, so it can be a small residential green area, something like farm, something like park (including public botanical gardens), also a more precise version of village green.

Therefore a more subtle change would be better - something like grass (general mild green) but with a pattern that shows that there's usually something more growing and it's human curated (hence regular pattern from plant nursery). I also opt for 60% opacity for the pattern, since I don't like the home gardens to stand up too much and also because the original pattern color has lower contrast because the background is darker.

Examples:
allv y1p
tphwddxr
8uzejybb
qnd3od_y

@kocio-pl kocio-pl changed the title Making gardens to use grass color with orchard pattern Making gardens to use grass color with plant nursery pattern Mar 1, 2018
@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Mar 1, 2018

Unfortunately grass areas in gardens are not too visible, but at least now they can be spotted:
rulxqtd_

@polarbearing
Copy link
Contributor

polarbearing commented Mar 1, 2018

I like the approach in general. Could we have a side-by-side comparison of the related renderings, i.e. garden, orchard, grass, park, nursery etc, in labelled thumbnail squares somehow? Thanks.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Mar 1, 2018

I don't understand what do you want - before/after garden renderings, a gallery of different green areas renderings or maybe something else?

Copy link
Collaborator

@matthijsmelissen matthijsmelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to get used to it, but after giving it some thought it is actually a quite sensible rendering.

@polarbearing
Copy link
Contributor

a gallery of different green areas renderings

Kind of that. Maybe it's worth a separate meta-issue? We are lacking a legend, either automatic #1928 or manual. Maybe we could make a requirement that each PR creates a standardized thumbnail that we can collect somewhere?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Mar 5, 2018

Discussion about legend belongs probably to #1928 - thanks for recalling, I'll write about it there.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Mar 6, 2018

@polarbearing Here is the main part of the green areas you wanted to see (the rest is in few other sections): https://wiki.openstreetmap.org/wiki/Standard_tile_layer/Key#Agriculture_and_industry

@kocio-pl kocio-pl merged commit 11ff4d9 into gravitystorm:master Mar 7, 2018
@kocio-pl kocio-pl deleted the garden branch March 7, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants