Adding amenity=bbq icon #3133
Adding amenity=bbq icon #3133
Conversation
I guess icon is enough. If this is in the recreation zone, it's easy to add such area in parallel. |
james2432
changed the title
amenity-points.mss
Outdated
| @@ -1906,7 +1913,8 @@ | |||
| } | |||
| } | |||
|
|
|||
| [feature = 'amenity_atm'][zoom >= 17] { | |||
| [feature = 'amenity_atm'][zoom >= 17], | |||
| [feature = 'amenity_bbq'][zoom >= 17] { | |||
| text-name: "[operator]"; | |||
There was a problem hiding this comment.
Name tag is used here, operator is not even visible in stats:
https://taginfo.openstreetmap.org/tags/amenity=bbq#combinations
There was a problem hiding this comment.
Something went wrong and - just by looking at code - you render operator instead of name again.
james2432
force-pushed
the
amenity_bbq
branch
2 times, most recently
from
ae03e62 to
dd18dac
Compare
|
Replaced operator use by name, not sure why I was using operator (was thinking maybe bbq's usually are operated by someone vs have a name?) |
|
Nice, could you also render a way with a name? Also please test updated code on a node (it should read "Dunlop Picnic"). |
|
After merging similar item ( |
|
Fixed. |
|
It renders OK and I'm gonna merge it, but could you make it 1 commit (instead of 2)? |
|
@kocio-pl of course you can do that yourself as well. |
|
I'm working on it, I just dont have access to git lfs on windows machine so I need a linux environment to download it should be done within next 20 minutes |
james2432
force-pushed
the
amenity_bbq
branch
2 times, most recently
from
86f4762 to
0fef15f
Compare
|
Done. |
|
Unfortunately we're back to the operator label (instead of a name label). |
|
Not sure what went wrong, possibly this computer didn't fetch my origin changes. Sorry about that |
|
No problem. Wait a moment, I test adv column now, so the conflicts will be back. |
|
Fixed the conflict issue with advertising |
|
Thanks! We are getting more outdoor lately (shower, bbq, fire pit, aerialways, shrines, towers...). That's great, OSM data are really diverse. |
Fixes #2996
From https://www.openstreetmap.org/node/4983372050#map=19/45.35162/-75.82804 (node):
From: https://www.openstreetmap.org/#map=19/43.31581/-70.92575 (way)
(Should we render ways with a border? or just the little icon?)From: https://www.openstreetmap.org/#map=17/45.51983/-75.84958 (node with text in name)
