Add amenity=clock icon #3135

james2432 · 2018-03-20T13:46:02Z

Fixes #3070
See comment below due to rework
~~From https://www.openstreetmap.org/#map=19/45.01689/-75.64647 (node)~~
~~Z18:~~

~~Z19:~~

HolgerJeromin · 2018-03-21T05:45:51Z

We had this idea in the past:

I think all allowed clocks should be rendered on zoom 19, but only clocks with visibility=area should be on zoom 18.

Tomasz-W · 2018-03-21T06:50:40Z

Please include in code:

clock areas (rendered as icon only)
zoom differentation from Add amenity=clock icon #3135 (comment)

lakedistrictOSM · 2018-03-21T14:09:37Z

Will places tagged with both amenity=clock and historic=monument
(like https://www.openstreetmap.org/node/456474545) get rendered with the clock icon or the monument icon?

Tomasz-W · 2018-03-21T20:51:25Z

Will places tagged with both amenity=clock and historic=monument
(like https://www.openstreetmap.org/node/456474545) get rendered with the clock icon or the monument icon?

I've checked this combination with Overpass Turbo and Google Earth, most of examples doesn't have any other function than being a clock, so amenity=clock tag should have a pririty there IMO.

james2432 · 2018-03-21T22:16:15Z

From: https://www.openstreetmap.org/#map=19/35.78917/-78.82883

Reworked to clock zoom 18 and needs visibility=area

dieterdreist · 2018-03-21T22:25:06Z

sent from a phone

On 21. Mar 2018, at 21:51, Tomasz Wójcik ***@***.***> wrote: I've checked this combination with Overpass Turbo and Google Earth, most of examples doesn't have any other function than being a clock, so amenity=clock tag should have a pririty there IMO.

for most commemorative clocks memorial seems fitting better than monument, as the latter should be accessible. You can’t see in google earth if something has a commemorative function, or maybe you can explain how?

Tomasz-W · 2018-03-22T06:21:32Z

Reworked to clock zoom 18 and needs visibility=area

@james2432 We mean to render all clocks on zoom 19 (visibility=* doesn't matter) and clocks with visibility=area on zoom 18

dieterdreist · 2018-03-22T07:07:43Z

sent from a phone

On 22. Mar 2018, at 07:21, Tomasz Wójcik ***@***.***> wrote: You can’t see in google earth if something has a commemorative function, or maybe you can explain how? street view :)

neither, I’d say it requires local knowledge

james2432 · 2018-03-22T12:35:36Z

@Tomasz-W I understand now, will tweak :) 👍

kocio-pl · 2018-03-22T21:50:11Z

It's important to test how does it look with churches/towers and stations - people may tag them on such objects, not only standalone clocks, and this might be making visual noise.

james2432 · 2018-03-24T14:33:26Z

Aparently they are never tagged with churches/towers:
https://taginfo.openstreetmap.org/tags/amenity=clock#combinations

kocio-pl · 2018-03-24T14:53:02Z

I meant "on the wall of the churches/towers", not "the churches/towers which are considered to be clocks" - this wouldn't make sense for me.

james2432 · 2018-03-24T15:01:15Z

do you have an example of a clock that is near a church?

kocio-pl · 2018-03-24T15:04:49Z

No, I don't.

lakedistrictOSM · 2018-03-24T15:26:10Z

Try https://www.openstreetmap.org/way/350214201#map=19/52.79738/-0.03797, https://www.openstreetmap.org/way/474490616 and https://www.openstreetmap.org/way/144553454

james2432 · 2018-03-25T00:08:03Z

https://www.openstreetmap.org/#map=19/51.31811/9.49671
Z18:

Z19:

https://www.openstreetmap.org/way/350214201#map=17/52.79765/-0.03705
Z18:

Z19:

https://www.openstreetmap.org/way/214357782#map=19/35.78913/-78.82871
Z18:

Z19:

Tomasz-W · 2018-03-25T06:31:57Z

I'm considering which tag should have priority, but in cases which I can imagine at the moment:
-amenity=clock > man_made=tower
-amenity=clock < man_made=tower + tower:type=bell_tower

kocio-pl · 2018-03-26T11:36:32Z

I would exclude at least support=wall ("The feature is supported by a wall.") and support=wall_mounted ("The feature is mounted on a wall."). Feel free to suggest something more, which indicates it's not a standalone clock or just a part of something more important (see https://wiki.openstreetmap.org/wiki/Key:support ). The example:

https://www.openstreetmap.org/node/2470273778

HolgerJeromin · 2018-03-28T06:31:37Z

I would exclude at least support=wall

This could lead to dropping this tag to get it rendered....

Tomasz-W · 2018-03-29T19:13:29Z

What about amenity=clock + advertising=column ? Which tag is more important in your opinion?

kocio-pl · 2018-03-29T19:50:38Z

@Tomasz-W The problem of objects with multiple tags is hard, basically I just rely on current code. Otherwise we should have complicated tools for chopping and moving some queries.

@HolgerJeromin Cheating is always possible, but there should be a way for a proper tagging to not make a visual mess in typical cases.

kocio-pl · 2018-04-04T19:35:14Z

@james2432 How are your plans about updating this code?

james2432 · 2018-07-02T22:28:31Z

Proof of exclusion for support = wall and support=wall_mounted
https://www.openstreetmap.org/way/458324854 (way, support=wall_mounted) (z19 ... z20 was also tested)

https://www.openstreetmap.org/node/5507892508 (node, support=wall_mounted) (z19 ... z20 was also tested)

https://www.openstreetmap.org/way/442511850 (way, support=wall) (z19 ... z20 was also tested)

https://www.openstreetmap.org/node/4294148104 (node, support=wall) (z19 ... z20 was also tested)

Also added the tags-> in parenthesis when using IS

kocio-pl · 2018-07-03T01:01:43Z

project.mml

@@ -1519,6 +1519,8 @@ Layer:
            tags->'tower:type' as "tower:type",
            tags->'castle_type' as castle_type,
            tags->'information' as information,
+            tags->'visibility' as "visibility",
+            tags->'support' as support,


Why "visibility" is in quotes and support is not?

purly esthetical, will add the quotes to follow others

project.mml

kocio-pl · 2018-07-03T01:02:45Z

project.mml

@@ -2343,6 +2349,7 @@ Layer:
          WHERE building IS NOT NULL
            AND building NOT IN ('no')
            AND name IS NOT NULL
+            AND NOT tags->'tower:type' IN('bell_tower')


Lacking space.

james2432 · 2018-07-03T01:30:21Z

https://github.com/james2432/openstreetmap-carto/blob/d0d9723662e8baaa5662e6091f172c7cea4dd8dd/project.mml#L2295

See purely esthetical, the other tags/column names are not enclosed with quotes here.

Added space.

Is there a coding standard that says all column names must be enclosed in quotes?

Zverik · 2018-07-03T12:12:11Z

project.mml

@@ -2343,6 +2349,7 @@ Layer:
          WHERE building IS NOT NULL
            AND building NOT IN ('no')
            AND name IS NOT NULL
+            AND NOT tags->'tower:type' IN ('bell_tower')


Better NOT IN, as above with building NOT IN ('no').

kocio-pl · 2018-07-03T12:15:28Z

I might have few days off without the access to the computer, so I will look at it soon after I'm back.

kocio-pl · 2018-07-03T12:15:42Z

Sorry, wrong button...

kocio-pl · 2018-07-11T17:48:51Z

This code is strange, it has two sections:

[feature = 'amenity_clock']["tower:type" != 'bell_tower'][feature != 'advertising_column'][zoom >= 18]

[feature = 'amenity_clock']["tower:type" != 'bell_tower'][feature != 'advertising_column']['support' != 'wall']['support' != 'wall_mounted'][zoom >= 19] {

Wall clocks should never be shown, because they are just a part of tower (unlike clock towers with multiple faces for example), not the landmarks in themselves.

Tomasz-W · 2018-07-24T18:18:13Z

@james2432 What's the state of this PR? Are you willing to finish it?

james2432 · 2018-07-24T18:19:57Z

well my laptop just died completely(motherboard), so I will be unable to continue this until I get a new one.

Tomasz-W · 2018-07-24T18:48:33Z

Oh, I understand. Anyway, I still hope that someday we will have these clocks and craft objects on map :)

Adamant36 · 2018-09-16T22:30:19Z

@kocio-pl, if I want to finish this do I do it by opening a new PR and noting that it closes this one along with the original issue or is there a certain procedure for that?

kocio-pl · 2018-09-16T22:32:07Z

New PR with closing comment will be OK.

james2432 · 2018-09-16T22:54:28Z

you can create a PR on my branch I will merge it, ai'm just unable to create new changes since I dont have a computer to work on it(using phone)

Adamant36 · 2018-09-16T23:05:48Z

OK cool. Creating a new PR here instead of on a branch might make it easier to deal with any subsequent issues that could come up.

@james2432, all that needs doing on it at this point is fixing rendering on walls?

Adamant36 · 2018-09-17T06:30:38Z

@james2432, I copied everything except the wall thing from your commit and although Kosmtik ran, I couldn't get it to display clocks on the map. If there anyway you could go over my code and see what I might be keeping them from displaying? https://github.com/Adamant36/openstreetmap-carto/tree/clock

Tomasz-W · 2018-09-17T06:52:03Z

@Adamant36 Oh, one more thing. Please change icon to "v1" version as it's obviously more clear than a "v2"

https://gist.github.com/Tomasz-W/07ed36017474669db82b11cb7f64dd26

matkoniecz · 2018-12-17T04:57:44Z

I am really, really sorry but I think that showing all clocks is not a good idea (in other words I think that underlying #3070 should be rejected).

Adamant36 · 2018-12-17T07:18:06Z

I thought it was a little wierd myself, but it seemed like it had some support at the time.

Its generally easy to go back to an issue after some time has passed, or the disscussion has died down, and to close it because it doesn't make sense in retrospect. You might not get any complaints either. Since everyone has pretty much left the building at this point. It still might be worth leaving open due to the earlier support though.

I was still planning on working on it eventual if james2434 never came back.

What specific issue do you have with it? Maybe some clocks could be displayed instead of all clocks or something.

Tomasz-W · 2018-12-17T13:29:14Z

Certain clocks are described by tags like e.g. support=* or visibility=* . I believe that by some rendering conditions we could filter them and add to map worth ones like sun clocks functioning as tourist attactions or big clocks functioning as orientation points etc. I hope @Adamant36 will prepare test renderings someday to show that it won't mess the map, but make it richer.

Adamant36 · 2018-12-17T21:21:04Z

@Tomasz-W if you want to open a new issue for the display of prominent ones as @matkoniecz suggests in the original issue I'd be willing to work on it when I get some time if I can. That would at least allow for some discussion of the pros and cons in the meantime though.

james2432 changed the title ~~[WIP] Issue #3070 Add amenity clock icon~~ [WIP] Add amenity clock icon Mar 20, 2018

kocio-pl changed the title ~~[WIP] Add amenity clock icon~~ [WIP] Add amenity=clock icon Mar 20, 2018

james2432 changed the title ~~[WIP] Add amenity=clock icon~~ Add amenity=clock icon Mar 20, 2018

james2432 force-pushed the amenity_clock branch from e3c3971 to 05ccfe4 Compare March 21, 2018 22:14

Tomasz-W mentioned this pull request Mar 22, 2018

Code needed to render prepared icons [meta ticket] #3105

Closed

13 tasks

james2432 force-pushed the amenity_clock branch from 05ccfe4 to 84993f8 Compare March 22, 2018 18:46

james2432 force-pushed the amenity_clock branch 2 times, most recently from 0537d22 to d542cb7 Compare March 24, 2018 23:59

james2432 force-pushed the amenity_clock branch from d0e029b to d0d9723 Compare July 2, 2018 22:28

kocio-pl requested changes Jul 3, 2018

View reviewed changes

james2432 force-pushed the amenity_clock branch from d0d9723 to dbb3019 Compare July 3, 2018 01:30

Zverik reviewed Jul 3, 2018

View reviewed changes

kocio-pl closed this Jul 3, 2018

kocio-pl reopened this Jul 3, 2018

Adding amenity=clock and fixing double text rendering

c9e7d33

james2432 force-pushed the amenity_clock branch from dbb3019 to c9e7d33 Compare July 3, 2018 12:34

Tomasz-W mentioned this pull request Jul 11, 2018

Good first issues [meta-ticket] #3298

Closed

26 tasks

james2432 closed this Dec 17, 2018

Tomasz-W mentioned this pull request Dec 18, 2018

Render prominent amenity=clock #3577

Open

Tomasz-W mentioned this pull request Jan 1, 2019

Good first issues [meta-ticket] #3617

Closed

19 tasks

Add amenity=clock icon #3135

Add amenity=clock icon #3135

Conversation

james2432 commented Mar 20, 2018 • edited Loading

HolgerJeromin commented Mar 21, 2018

Tomasz-W commented Mar 21, 2018

lakedistrictOSM commented Mar 21, 2018

Tomasz-W commented Mar 21, 2018

james2432 commented Mar 21, 2018

dieterdreist commented Mar 21, 2018 via email

Tomasz-W commented Mar 22, 2018 • edited Loading

dieterdreist commented Mar 22, 2018 via email

james2432 commented Mar 22, 2018

kocio-pl commented Mar 22, 2018

james2432 commented Mar 24, 2018

kocio-pl commented Mar 24, 2018

james2432 commented Mar 24, 2018

kocio-pl commented Mar 24, 2018

lakedistrictOSM commented Mar 24, 2018

james2432 commented Mar 25, 2018

Tomasz-W commented Mar 25, 2018

kocio-pl commented Mar 26, 2018

HolgerJeromin commented Mar 28, 2018

Tomasz-W commented Mar 29, 2018

kocio-pl commented Mar 29, 2018

kocio-pl commented Apr 4, 2018

james2432 commented Jul 2, 2018

kocio-pl Jul 3, 2018

Choose a reason for hiding this comment

james2432 Jul 3, 2018

Choose a reason for hiding this comment

kocio-pl Jul 3, 2018

Choose a reason for hiding this comment

james2432 commented Jul 3, 2018

Zverik Jul 3, 2018

Choose a reason for hiding this comment

james2432 Jul 3, 2018

Choose a reason for hiding this comment

kocio-pl commented Jul 3, 2018

kocio-pl commented Jul 3, 2018

kocio-pl commented Jul 11, 2018

Tomasz-W commented Jul 24, 2018

james2432 commented Jul 24, 2018

Tomasz-W commented Jul 24, 2018

Adamant36 commented Sep 16, 2018

kocio-pl commented Sep 16, 2018

james2432 commented Sep 16, 2018

Adamant36 commented Sep 16, 2018 • edited Loading

Adamant36 commented Sep 17, 2018

Tomasz-W commented Sep 17, 2018

matkoniecz commented Dec 17, 2018

Adamant36 commented Dec 17, 2018

Tomasz-W commented Dec 17, 2018

Adamant36 commented Dec 17, 2018

james2432 commented Mar 20, 2018 •

edited

Loading

Tomasz-W commented Mar 22, 2018 •

edited

Loading

Adamant36 commented Sep 16, 2018 •

edited

Loading