Removing objects without background/outline from landcover data layer #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if I fully understand the need for this PR? Also, why did we have these features in the table in the first place, if we don't need them? |
|
It's just code cleaning. They were probably added because some similar objects were there - or maybe in a hope that soon some kind of area/outline rendering will be defined, but they are not styled currently. This is why #2452 would be useful - I wouldn't miss/introduce them if the change was in the clearly named whitelist instead of large SQL statement inside even bigger layer. |
|
Ok, clear! |
matthijsmelissen
approved these changes
Mar 29, 2018
|
I see now, for example shower was introduced in #3134. |
|
Yes. On the other hand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix triggered by finding this bug: #2440 (comment).
Objects with no area/outline rendering should not be selected in the landcover data layer. It might go unnoticed most of the time - for example it's hard for me to imagine firepit area with any kind of background, like grass - but if this area is tagged also with something using landcover features, it can lead to lack of the background/outline of the second feature.