Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering icon for shop=food #3430

Closed
wants to merge 1 commit into from
Closed

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Oct 6, 2018

Changes proposed in this pull request:

  • Rendering shop=food with the restaurant icon, but mirrored (to make it easier to recognize)

Node (in comparison with restaurants)

x7qm0w6w

Area

9l6vfok

Usage

taghistory 54

@Tomasz-W
Copy link

Tomasz-W commented Oct 6, 2018

I think that both icons should be mirrored once again (if you want them different from each other). A correct table set is a fork on the left side and a soup spoon on the right side (see here). It would be logical to revert restaurant icon as dinner starts by soup and most of people are right-handed so spoon should be on the right side.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 6, 2018 via email

@Adamant36
Copy link
Contributor

@jeisenbe, probably just a more generic, default type tag for "I don't know what exactly this place is, but I know it involves food somehow." Id say render it just for that. Its better then nothing. Plus, its not technically wrong. Since the places are food shops.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 6, 2018 via email

@meased
Copy link
Contributor

meased commented Oct 6, 2018

Perhaps reusing the shop=convenience icon? They are somewhat like a specialized convenience store (walk in, buy a few items, and leave without eating it).

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Oct 6, 2018

Before I start digging into @jeisenbe questions, which are worth checking, but require some time and reading about English vocabulary, I can propose a shop bag with a fork for example (similar to charity shop).

I also think that reworking restaurant icon is perfectly possible. It's just good to think also about food court - currently they look the same. Maybe they could be a bit different. I thought about showing it with this icon on z17, instead of a dot, to show that it's bigger space, but we can also do something more.

@matthijsmelissen
Copy link
Collaborator

I think shop=food is almost always a mistagging of shop=supermarket, shop=convenience or shop=deli.

Copy link
Collaborator

@matthijsmelissen matthijsmelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm against rendering this tag, as the meaning of the tag is not clear.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Oct 7, 2018

@jeisenbe Thanks a lot for writing about it on the Tagging list! ❤️ I'd be happy to know the differences at last...

https://lists.openstreetmap.org/pipermail/tagging/2018-October/039710.html

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 7, 2018 via email

@matkoniecz
Copy link
Contributor

Report on tagging mailing list was quite convincing. It seems that most of usage is mistaggings or unifnished work, so I think that it should be rendered as a generic dot shop or not rendered at all.

@dieterdreist
Copy link

dieterdreist commented Oct 7, 2018 via email

@dieterdreist
Copy link

dieterdreist commented Oct 7, 2018 via email

@jragusa
Copy link
Contributor

jragusa commented Oct 7, 2018

I agree to reject this rendering but as @Tomasz-W suggested, we should flip the restaurant icon.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Oct 7, 2018

I don't think it's worth digging more now, there are other interesting PRs to take care of, but for a shop selling only home food (like dumplings+pancakes) ready to boil I don't think convenience or grocery (let alone supermarket!) makes any sense - and general is too general for this.

It's also good that we have such generic values - it's like building=yes: if I know only this, it's better to tag it according to my knowledge, maybe it will be tuned later.

Thanks for all the comments!

@kocio-pl kocio-pl closed this Oct 7, 2018
@kocio-pl kocio-pl deleted the food branch October 7, 2018 15:33
@Tomasz-W
Copy link

Tomasz-W commented Oct 7, 2018

@kocio-pl What about flipping amenity=restaurant icon due to reasons mentioned in #3430 (comment)?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Oct 7, 2018

I have nothing against it, I'm just focused on other issues. Typically this is knife and a fork, but spoon also works for me.

@Tomasz-W
Copy link

Tomasz-W commented Oct 9, 2018

Restaurant icon update proposals:

  • amenity restaurant2 (fork + spoon)
  • amenity restaurant2 (fork + knife)

@Tomasz-W Tomasz-W mentioned this pull request Oct 14, 2018
@Slawek234
Copy link

Slawek234 commented Oct 14, 2018

sign
Both symbols are common. A spoon is required when eating soup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants