Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for amenity=public_bookcase #3462

Merged
merged 3 commits into from
Nov 3, 2018
Merged

Add icon for amenity=public_bookcase #3462

merged 3 commits into from
Nov 3, 2018

Conversation

Adamant36
Copy link
Contributor

@Adamant36 Adamant36 commented Oct 20, 2018

Closes #1288

This PR adds rendering for amenity=public_bookcase. Its a pretty well used tag already and the usage seems to be increasing. So why not? I left rendering to start at z19 because otherwise ones with names risk covering up addresses or other more important information. Also, its not suppose to be mapped on ways and there's only like 100 out of 2000ish mapped that way. So, I didn't do a test on them.
taghistory
https://www.openstreetmap.org/#map=19/37.76514/-122.45442
public bookcase z19 1
https://www.openstreetmap.org/#map=19/37.75058/-122.41776
public bookcase z19 2

@Tomasz-W Tomasz-W mentioned this pull request Oct 20, 2018
26 tasks
@sommerluk
Copy link
Collaborator

Looks rather like a library for me…

@SomeoneElseOSM
Copy link
Contributor

@sommerluk

Looks rather like a library for me

In a different style I couldn't think of a good differentiating icon so went with a small "L" (which wouldn't be appropriate here). If you can think of a better idea I'd be all ears :)

Just to add another idea, maybe change "library" to incorporate the idea of "building" (like here for a different icon for a different thing, just as an example)

Copy link
Contributor Author

@Adamant36 Adamant36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kocio-pl, sorry about that. I fixed it.

@Adamant36
Copy link
Contributor Author

@kocio-pl, my bad. I fixed it.

@sommerluk
Copy link
Collaborator

Maybe having a line on the left, right and bottom, symbolizing an (open) box?

@Tomasz-W
Copy link

Tomasz-W commented Oct 20, 2018

I've fastly made 2 more propositions:

  • amenity public_bookcase2 (v2)
  • amenity public_bookcase (v3)

Gist link: https://gist.github.com/Tomasz-W/164f3f591a59e33d6d6663e2b0564033

@Adamant36 Please test them.

@polarbearing
Copy link
Contributor

I'd prefer @somerluk's idea, the shelf by @Tomasz-W is not recognisable to me.

@Tomasz-W
Copy link

@polarbearing
Copy link
Contributor

Sorry @Tomasz-W but my best interpretation is a book being raked. It does not work for me as the book is much larger than the self spaces.

@kocio-pl
Copy link
Collaborator

For me even the same icon as library would be OK, because it's similar idea, but just much smaller size, so it's enough to see that it's rendered later.

@meased
Copy link
Contributor

meased commented Oct 20, 2018

Really quick idea combining the library and shelter icons:

bookcase

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Oct 20, 2018

perhaps this is an candidate for a grey color, too. But I do not remember the logic for grey vs brown

@Tomasz-W
Copy link

Tomasz-W commented Oct 21, 2018

Continuating @meased idea:

  • thinner "roof" shape and bigger library icon to make it more readable:

amenity public_bookcase1

  • the same with closed book shape:

amenity public_bookcase2

Gist link: https://gist.github.com/Tomasz-W/164f3f591a59e33d6d6663e2b0564033

I'm not sure about using library icon here, because library is a place where you can sit and read in silence, public bookcases are something totally different - you just check short book description and take it home or not, so using library icon might be a little bit confusing. What do you think?

@kocio-pl
Copy link
Collaborator

library is a place where you can sit and read in silence,

No, it's a reading room. Some libraries may have it, but it's not essential, just like some of them can lend multimedia for example.

@polarbearing
Copy link
Contributor

The open book with roof is good. We should not have too many different symbols based on a book .

@Adamant36
Copy link
Contributor Author

I prefer the open book with roof also. Can we go with it?
public_bookcase

@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 3, 2018

I think this is good solution.

@Adamant36
Copy link
Contributor Author

@kocio-pl, its been updated.

@kocio-pl kocio-pl merged commit 5efe7c9 into gravitystorm:master Nov 3, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 3, 2018

Thanks! It works as expected for both named nodes and named areas.

@Adamant36 Adamant36 deleted the bookcase branch November 3, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants