-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon for amenity=public_bookcase #3462
Conversation
Looks rather like a library for me… |
In a different style I couldn't think of a good differentiating icon so went with a small "L" (which wouldn't be appropriate here). If you can think of a better idea I'd be all ears :) Just to add another idea, maybe change "library" to incorporate the idea of "building" (like here for a different icon for a different thing, just as an example) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kocio-pl, sorry about that. I fixed it.
@kocio-pl, my bad. I fixed it. |
Maybe having a line on the left, right and bottom, symbolizing an (open) box? |
I've fastly made 2 more propositions: Gist link: https://gist.github.com/Tomasz-W/164f3f591a59e33d6d6663e2b0564033 @Adamant36 Please test them. |
I'd prefer @somerluk's idea, the shelf by @Tomasz-W is not recognisable to me. |
Sorry @Tomasz-W but my best interpretation is a book being raked. It does not work for me as the book is much larger than the self spaces. |
For me even the same icon as library would be OK, because it's similar idea, but just much smaller size, so it's enough to see that it's rendered later. |
perhaps this is an candidate for a grey color, too. But I do not remember the logic for grey vs brown |
Continuating @meased idea:
Gist link: https://gist.github.com/Tomasz-W/164f3f591a59e33d6d6663e2b0564033 I'm not sure about using library icon here, because library is a place where you can sit and read in silence, public bookcases are something totally different - you just check short book description and take it home or not, so using library icon might be a little bit confusing. What do you think? |
No, it's a reading room. Some libraries may have it, but it's not essential, just like some of them can lend multimedia for example. |
The open book with roof is good. We should not have too many different symbols based on a book . |
I think this is good solution. |
@kocio-pl, its been updated. |
Thanks! It works as expected for both named nodes and named areas. |
Closes #1288
This PR adds rendering for amenity=public_bookcase. Its a pretty well used tag already and the usage seems to be increasing. So why not? I left rendering to start at z19 because otherwise ones with names risk covering up addresses or other more important information. Also, its not suppose to be mapped on ways and there's only like 100 out of 2000ish mapped that way. So, I didn't do a test on them.



https://www.openstreetmap.org/#map=19/37.76514/-122.45442
https://www.openstreetmap.org/#map=19/37.75058/-122.41776