Add rendering for healthcare tag scheme

[jragusa]

Fixes #2938

Changes proposed in this pull request:

• change health-color to #CC0000 #BF0000
• change icon of hospital
• add support of healthcare tag scheme with a dot from z17
• support duplicated healthcare tags with amenity tags (clinic/dentist/doctors/hospital)
• move icon ofamenity/healthcare=dentist to z18 and display a dot at z17
• move amenity/healthcare=clinicto z17
• preserve priority of amenity=pharmacy if tagged in combination with healthcare=*

Test rendering with links to the example places:
https://www.openstreetmap.org/way/337002580 (new hospital icon and colour)
Before

After (fix correct picture)

https://www.openstreetmap.org/#map=17/46.19317/6.23683 (zoom level and dots)
z17
Before

After

z18
Before

After

[Tomasz-W]

support duplicated healthcare tags with amenity tags (clinic/dentist/doctors/hospital)

@jragusa Please add also amenity=pharmacy as priority one in case if there will be combination with healthcare=* to show an icon instead of dot then.

[jragusa]

@Tomasz-W fixed

[Tomasz-W]

@jragusa Just one more thing: I'm wondering if #CC0000 isn't too prominent comparing it to other icons, can you test a little bit darker #BF0000?

Edit: Are all of healthcare=* tags included (I mean it like every office=* has at least a dot) due to #2938 (comment)?

[jragusa]

#BF0000

[jragusa]

@Tomasz-W yes I included the healthcare tags following this comment and they are all displayed as a dot.

[jeisenbe]

Have you tested it next to a named retail area and next to trunk roads and motorways? Those retail name labels are fairly red.

…

On Wed, Nov 7, 2018 at 11:21 PM Jérémy Ragusa ***@***.***> wrote: @Tomasz-W <https://github.com/Tomasz-W> yes I included the healthcare tags following this comment <#2938 (comment)> and they are all displayed as a dot. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3498 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshLx565SusgwSN2FouU2fDAb3fYjlks5usuyBgaJpZM4YQkcZ> .

[jragusa]

@jeisenbe do you have an example of location ?

[jragusa]

found it: https://www.openstreetmap.org/#map=17/46.34787/6.43486

[Tomasz-W]

1. I prefer darker one #BF0000
2. I think there would be no big problem with similarity with retail areas - they have bigger and italic font on a pink background and healthcare object has smaller non-italic font on a yellow background (hospital areas)

[Tomasz-W]

@jragusa I've read some posts again, and there is a little misunderstanding, sorry for it. I mean to render every heanlthcare=* object with a dot at least, even e.g.healthcare=gummy_bears_doctor (no matter of value). We have the same for shop=* and office=* keys and it's not causing any big problems. In this way we avoid series of issues named "Add rendering for healthcare=..." in the future.

[matkoniecz]

render every heanlthcare=* object with a dot at least, even e.g.healthcare=gummy_bears_doctor (no matter of value)

I think that rendering freeform values is not preferable. With shops it may be acceptable as there are some weird rare shop, but in case of healthcare I would expect that all uses are covered by tagging scheme.

[Tomasz-W]

Here is a TagInfo list of healthcare=* values in use: https://taginfo.openstreetmap.org/keys/healthcare#values . There is a lot of less known and undocumented
(but still reasonable) values, so I don't see a problem with allowing all of them as red dots.

[jragusa]

@Tomasz-W Sorry, it was a misunderstood from my side.

So what's the plan now ? Do I restrict following the TagInfo list or open to any value (healthcare=*) ?
There is only 2 values missing in my PR (pharmacy and hospice).

[Tomasz-W]

@jragusa open to any value (like shops and offices are)

[matkoniecz]

I would restrict list to the documented values.

[kocio-pl]

This case is not easy to decide. From one side - shops have much longer list of values and they do not have a global definition, while we have Healthcare 2.0. On the other hand having healthcare=* has very clear meaning and is limited by that, unlike gastronomy objects for example - they use generic amenity=* space, which makes it impossible to use such easy limits.

[matkoniecz]

I think that it this case better mapper feedback would be to encourage use of documented values or documenting them if something is missing.

While in case of shops I see why rendering shop=gummy_bears may be considered desirable, I think that in this case not rendering, say healthcare=gummy_bears_doctor is desirable.

[kocio-pl]

I think your proposition is perfectly valid for now. We can review this decision later if anyone will complain or just extend the rendering when documentation will be extended. Rendering healthcare is a big step ahead in itself, so we may stay on the safe side and see how it works.

[jragusa]

So, I restrict following the TagInfo list for now ?

[kocio-pl]

There are still chiropractor entries in project.mml instead of dialysis, unfortunately. Please replace them and make sure it works. The rest looks OK.

[jragusa]

I made tests for chiropractor and dialysis. It now work fine.

Sorry, for this trivial error, sometimes, I have my head in the clouds.

[kocio-pl]

A lot of work, but I think it was worth all the hassle. Thanks for your dedication and patience!

I think we will come back to this namespace sooner or later, I'm not only sure which one is more true in this case.

[geozeisig]

Can someone tell me why the icon for the Charité has no name on the map?

[kocio-pl]

Most probably because of the road labels and road arrows.

[kocio-pl]

See also #2429.

[geozeisig]

I give up. I've already changed a lot but the conflict persists rendering the name of Charité.

[kocio-pl]

I would be surprised if anything would change without solving problem I mentioned lately. If you could try to solve it, the chances are high in my opinion. Anybody else interested in fixing this?

[Adamant36]

Personally I think its miss-tagged. Things there don't seem to fit the Wiki definition of a hospital. For instance the Institute of Chinese Life Sciences, which is north of the icon but still within the hospital bounds. You might try mapping the area as a university. Since that's what it actually is, even though some places in it provide patent services, and then applying the hospital tag to a more specific area like a building or something. Maybe university would render before hospital. So the name would display.

That's what I did for the college near where I live, that also provides dental services and things through internships and it seems to work. I don't think your going to get the name of the hospital to display otherwise. considering how many other things are rendering inside the area. I think its stretching the definition of a hospital a lot as it is anyway (I know from research that a lot of the services it provides would probably be under the amenity=clinic tag instead). Some places like haritéCentrum 15 für Neurologie, Neurochirurgie und Psychiatrie might qualify as social facilities for people with mental health problems also.

[geowas-github]

Personally I think its miss-tagged. Things there don't seem to fit the Wiki definition of a hospital. For instance the Institute of Chinese Life Sciences, which is north of the icon but still within the hospital bounds. You might try mapping the area as a university. Since that's what it actually is, even though some places in it provide patent services, and then applying the hospital tag to a more specific area like a building or something. Maybe university would render before hospital. So the name would display.

Which is tagging for the renderer.

Certainly Charité is both a hospital and (part of) a university, but the main purpose for its existence is that it is a hospital (incorporating education). And for the other point: Most hospitals also provides amenity=clinic type services.

[Adamant36]

Its not tagging for the renderer if its miss-tagged in the first place and tagging it properly also happens to get the name to display.

I wasnt suggesting just picking random tags until one worked. Which would qualify as tagging for renderer. The buildings should be properly tagged either way. Its missleading to just tag the whole area as a hospital and call it a day when it provides a bunch of other services that can also be tagged.

Plus, I noticed the whole area is tagged as emergecy=yes and wheel_chair=yes. surely some of the buildings provide emergecy services and some of the compound is wheel chair friendly, but I doubt the whole does or is.

Anyway, its not a tagging disscussion. Except in the case where tagging might possibly be causing the problem. So it really doesnt matter outside of that.

[geozeisig]

The Charité is certainly one of the largest hospitals in Berlin. The acute operations are done here. And the patients are lying here afterwards. In the other houses are also patients and they are also part of the hospital. I did not understand what you need to change to show the name?

[geowas-github]

@Adamant36: even if we would tag Charité as university: why should it be rendered differently than a university and be hidden behind "road labels and road arrows" while the university is not. Science before road labels before charity?

BTW: I don't think there is a clear sceme for tagging hospitals linked to universities. If I look at the Universtitätsmedizin Mainz here around the corner: to most people it's clearly a hospital first of all. For students of medicine it will be the university. Either way: neither tagging the area as a hospital with university nodes/smaller areas or a university with hospital nodes/smaller areas inside will be correct. It's all mingled, so one has to decide for one (whatever). But this doesn't help solving the question why there is no text lable for Charité.

[kocio-pl]

What about healthcare=hospital + amenity=university?

[geozeisig]

The university is certainly not the reason. The campus area is displayed correctly and does not overlap. Of course, the students go to the hospital.

[Adamant36]

@geozeisig, there's a part here where the hospital grounds almost overlaps itself and there's a whole in it with a weird yellow line going south a bit. It might have something to do with that. There was a hospital a while back in the bay area somewhere where the icon displayed a few yards away from the hospital in a residential area and the name didn't rendering. It was because of a similar issue. I was never able to fix it unfortunately, but if there's not a clear center for the icon and name render or anything overlaps itself it tends to cause rendering problems. So you might check that (I would have fixed it myself but I don't want to screw with the area and the website keeps giving me a loading error for some reason).

[Adamant36]

Instances of other places where the hospital name doesn't display correctly (not sure why. Could be rendering priority).

https://www.openstreetmap.org/#map=18/37.59184/-122.38181

https://www.openstreetmap.org/#map=18/37.67947/-122.47399 (only doesn't renders name at z18. Might be road oneway arrow blocking it)

https://www.openstreetmap.org/#map=18/37.37604/-122.06447 (doesn't render name at z17. Not sure why).

https://www.openstreetmap.org/#map=17/37.33501/-121.99849 (It blocks itself out in this situation. Probably miss-tagging).

https://www.openstreetmap.org/#map=19/37.33342/-121.88524 (another example of where the name is being blocked out by other stuff due to rendering priority. In this instance a post office, but zoom out).

I guess road labels take rendering priority over POI's in most cases?

[geozeisig]

I've simplified something else. And now it works.

Whether it really is related to my recent changes, I can not believe, because it was only a few minutes later. The server was down this morning, so we better wait.