Add aboriginal areas

[almccon]

Fixes #3520

Changes proposed in this pull request:

• Add rendering for boundary=aboriginal_area and for boundary=protected_area + protect_class=24.

Test rendering with links to the example places:

Before

After

More samples:

[pnorman]

👍 in principle, I haven't done a detailed code review.

[kocio-pl]

As I have written in the issue ticket, it's not easy to find good color - this rendering might be too close to the zoo. So maybe we need some dark orange border; of course the colors can be switched (brown-orange for aboriginal area and orange for zoo) if that would work better. That needs testing. Also wiki documentation is needed, following discussion on the Tagging list to make sure if we really need 2 different schemes (maybe we do).

Another, smaller issue would be to rename data layer into something like protected-areas-boundaries instead of creating another similar layer called aboriginal-lands-boundaries.

[jeisenbe]

@almccon, if the orange doesn't work, another option would be to switch tourism boundaries (eg zoos, theme parks) to a shade of violet or purple, because we are planning to change administrative boundaries to gray, thus making purple available for tourism features.

[sommerluk]

If violet becomes available, it should not be a minor feature like this one to occupy it again (blocking a hole coulor).

[jeisenbe]

Lukas Sommer wrote:

If violet becomes available, it should > not be a minor feature like this

one to > occupy it again Zoos an amusement parks are fairly minor, but we could use the same border for many other tourist areas and accommodations: e.g. resorts, campsites, caravan sites, etc. Violet is a rather strong color an uncommon in nature, so I think it should be used for less common but interesting features; tourism and transportation are good options. But if orange works, that could also be a good option for tourism.

[Adamant36]

Isn't violet/purple being used for shops currently? I think it works good there. The new gastronomy icon is sort of orangish already also. Maybe the dark blue color that's currently being used for railway stations would work. Since its the only thing that I know of with the color.

There was a discussion somewhere around here about changing that and a few other colors around that never went anywhere. Maybe it would be worth revisiting and putting this stuff/that stuff under one umbrella. Since they are all sort of related. As far as zoos, amusement parks etc goes. I think it would be the wrong color for this issue though.

Orange might actually work here despite its food association because I doubt people think aboriginal areas are related to restaurants. Plus, its kind of an earth tone. Which sorta fits.

[matkoniecz]

Thank you very much for a PR! Especially such well formatted one (with example images etc).

Unfortunately currently proposed rendering is far too close to rendering of zoos/theme parks. I understand that with style rendering so many features it is hard to find style that works is not already used for something else but in this case implication of rendering this feature in style very close to zoos are quite problematic.

Can you experiment with some other stylings?

[matkoniecz]

@almccon Would it be OK to mark this PR as assigned to you for now?

[almccon]

@matkoniecz Yes, please go ahead and assign it to me, thanks. I will try some alternative color treatments to avoid the zoo conflict. I just haven't had time to do it yet.

[kocio-pl]

We have now boundary=aboriginal_lands documented:

https://wiki.openstreetmap.org/wiki/Tag:boundary%3Daboriginal_lands

and i agree that we should now render both schemes.

So, we just wait for solving rendering problems.

[jeisenbe]

@almccon, here are some options for changing the tourism color (currently brown, used for tourism=zoo and tourism=theme_park). Tourism=attraction uses #660033, but I would like to change this to be the same.

Here's the current rendering of this test area that I created in JOSM (which shows province and national borders as well as several landuse colors that may be relevant):
Current style
z15

z16

z17

#660033

• this uses the current tourism=attraction color for zoos and theme parks as well
• It may work even without changing the administrative boundary colors
  z15
  
  z16
  
  z17
  

Orange

• This test is with #C77400,
  z15
  
  z16
  
  z17
  

Dark violet #864784

• Too similar to current administrative boundary color; so this might need to be changed first.
  z15
  
  z16
  
  z17
  

[kocio-pl]

#660033 for attractions looks great for me. But I think this should be discussed in separate PR.

[jeisenbe]

Separate PR or separate issue? I’m happy to make a PR, unless @almccon would like to do it.

…

On Thu, Dec 20, 2018 at 11:19 AM kocio-pl ***@***.***> wrote: #660033 for attractions looks great for me. But I think this should be discussed in separate PR. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3521 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshCDwwJUJ5fFwrnITgtIl64RJr4RWks5u6vO6gaJpZM4Yv4r6> .

[kocio-pl]

I guess #3045 covers it already and it's time to move to the next level - real code.

[kocio-pl]

@almccon Quoting myself:

Another, smaller issue would be to rename data layer into something like protected-areas-boundaries instead of creating another similar layer called aboriginal-lands-boundaries.

More layers create additional performance penalty and all these objects are equal in rendering (none of them should have rendering priority over the other), so it does not make sense to create additional data layer.

This is probably the last thing to be done here, the rest is just waiting for #3582 to be merged.

[kocio-pl]

@almccon Ping?

Now the #3582 is merged, so merging this depends only on your action.

[jeisenbe]

@almccon - do you have time to update this PR to fix the merge conflicts and per the suggestion in #3521 (comment)?

If not, I could finish it for you (by submitting a new PR)

[kocio-pl]

@jeisenbe I believe you can make your own PR now to fix this.

[almccon]

Hi all, sorry for the delay. I fixed the merge conflict, and I'll try to respond to the other comments tomorrow. But if you want to jump on any of it, be my guest @jeisenbe!

[jeisenbe]

Go ahead, I think you’ve got it.

…

On Wed, Jan 23, 2019 at 2:36 PM Alan McConchie ***@***.***> wrote: Hi all, sorry for the delay. I fixed the merge conflict, and I'll try to respond to the other comments tomorrow. But if you want to jump on any of it, be my guest @jeisenbe <https://github.com/jeisenbe>! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3521 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshF3_Tw0Zva2LlkeCCipqIQEnsLxLks5vF_TPgaJpZM4Yv4r6> .

[almccon]

Okay, @kocio-pl, I combined the two layers into a single layer as per the suggestion in #3521 (comment)

In this branch, the aboriginal areas are #82643a, and thanks to #3582 zoos and other tourism are #660033. The aboriginal brown is lighter than the original tourism brown #734a08, which is still used for amenity points.

This feels like a good outcome to me. I don't think there are any other outstanding issues. Did I miss anything?

[kocio-pl]

Did you actually test the code (for both cases) after the changes? It is a common thing to do after each change to avoid errors.

I get SQL error when trying to render anything with this code:

Postgis Plugin: ERROR: column "boundary" does not exist

If you need some help, please talk with @jeisenbe probably.

[almccon]

I did test the code, and I did see that error happen initially after I made the code change, but then when I restarted docker I thought I stopped seeing the error. Let me check again.

[almccon]

You're right, that error is showing up for me at z13+, due to the protected-areas-text layer not including the boundary and class column. My fault. Should be fixed now.

[kocio-pl]

Thanks, now it works, but the text label color is wrong here for example:

https://www.openstreetmap.org/relation/2740289#map=10/9.9377/-72.9568

[kocio-pl]

Looks like the problem exists only for boundary=protected_area + protect_class=24 but not for boundary=aboriginal_lands:

https://www.openstreetmap.org/way/383485661#map=14/20.6472/-103.2405

[almccon]

Ugh, sorry. I thought I had tested the label color on boundary=protected_area + protect_class=24, but apparently I did not. I just pushed another commit that should fix the problem.

[kocio-pl]

It works now, it just needs some code cleaning (I have not repeated it for every occurrence).

[almccon]

Thanks for the feedback, all of those code cleanup recommendations are good, and I think I've applied them all.

[kocio-pl]

Now it looks OK for me. Thanks for all this work!