Add more barrier icons #3602
Add more barrier icons #3602
Conversation
|
Great to see these being added! |
|
I'm not sure about kissing gate icon: it's bigger than simple gate icon while it's usually smaller than car gate in real life, another thing is that icons can't be rotated to show a proper side of an entrance. I consider reusing curent gate icon instad of dedicated one. What do you think? @Adamant36 Can you test turnstiles in these locations?: |
|
I dont know. I like the kissing gate icon. Even if its bigger. The normal gate icon is pretty tiny. So I think its more on that. Their different things anyway. Plus, the current gate tagging is also used for pedestrian walkway gates in front houses. Its not just exclusive to cars. I'll test it. You want it done with the bollard dot or with an icon? |
Bollard dot. The thing is that turnstiles are often mapped very dense and underground, so it may be unreadable and it needs testing to decide should we render them or not. |
|
Motorcycle barriers look like a pliers and the vertical shape is not intuitive. Why not using the same for both motorcycle and cycle barriers ? |
|
Google pictures of them. They dont look the same in real life. The motorcyle barrier looks pretty close to how it looks in real life. |
|
@Tomasz-W, here you go. I think all the locations look OK. Location 1 and 2 in particular should probably be tagged as lines anyway. |
I would agree, looking at that symbol on the map I would instantly know what it is without needing to look at that the map legend. |
|
What are everyone's thoughts with regards to rendering |
|
To be honest, cycle barrier is not intuitive to me either - but I don't know if we can come up with something better? |
|
It looks like the picture of the cycle barrier on the wiki from above at least. I think the fact that its tagged on a highway would help to. Theres only a small number of things it could be. Plus, I dont know how else the icon could look. |
|
@matthijsmelissen, I wouldn't necessarily call this a WIP. There doesn't seem to be a next step in the testing process anywhere. Unless I'm missing something. Someone just saying they don't like an icon doesn't really count as needing more work in my opinion (especially if they don't provide an alternative and the vast majority of people are for it). So I think its ready for testing/merging by an admin. |
|
I wasn't sure if there's anything else you wanted to do with the suggestions given. Thanks for indicating it's ready, going to review it then! |
I think it's a misconception that icons should look like the object they depict. The best icons often don't. Clothes shops don't look like t-shirts, night clubs don't look like music notes, and churches don't (necessarily) look like crosses. |
|
I'm going to merge this now. If anyone has ideas for better icons, feel free to submit icons. @Adamant36 Just a small note, in the future please be careful not to introduce unnecessary whitespace at the end of lines. |
|
My bad. I thought I checked it. Thanks for merging it. |
Does that mean the next time I don't like an icon that I can argue against it by saying it doesn't look abstract enough? |
No, but you cannot argue that something is a good icon just because it looks like the object its depicting. |
|
Hhhmmm, good distinction. I guess a bunch of almost photo realistic icons would probably look horrible, even if they are close to what they are representing. |
|
Please open new ticket with this proposition. |
This PR adds more icons for barriers. It closes #846
Motorcycle barrier
https://www.openstreetmap.org/#map=19/53.20660/-1.41045
Cycle barrier
https://www.openstreetmap.org/#map=19/53.22609/-1.41716
Kissing gate
https://www.openstreetmap.org/#map=19/52.45566/-1.58009
Full height turnstile
https://www.openstreetmap.org/#map=19/52.19147/-1.48791
Turnstile
https://www.openstreetmap.org/#map=19/51.50322/-0.11377
Lots of gratitude to everyone involved, especially @Tomasz-W for making the icons and keeping track of everything.