Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import waterway=tidal_channel as a linestring #4014

Merged

Conversation

jeisenbe
Copy link
Collaborator

Related to #3611 and #3865

Changes proposed in this pull request:

  • Add waterway=tidal_channel to the list of linestring exceptions in openstreetmap-carto.lua so that closed ways with this tag will only be imported as a linestring
  • This tag is only used on lines, similarly to waterway=stream and waterway=river
  • While it is not currently rendered, there are over 2,500 features with this tag: https://wiki.openstreetmap.org/wiki/Tag:waterway=tidal_channel
  • Adding this to the lua transformations file will make it easier to render this feature correctly in the future or in other map styles which are based off of this style.

Add waterway=tidal_channel to the list of linestring exceptions in openstreetmap-carto.lua so that closed ways with this tag will only be imported as a linestring
@jeisenbe jeisenbe added the lua label Jan 28, 2020
@jeisenbe jeisenbe merged commit 2c64259 into gravitystorm:schema_changes Feb 2, 2020
@jeisenbe jeisenbe deleted the schema-tidal_channel branch February 2, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants