Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows line ending fix #4330

Merged
merged 3 commits into from
Feb 10, 2021

Conversation

ZeLonewolf
Copy link
Contributor

Fixes #4329

Adds .py files to the list of files that should be excluded from git CRLF conversions.
This has been tested on Windows, but needs to be tested on Linux to ensure no unexpected behavior.

@matkoniecz matkoniecz self-requested a review February 10, 2021 14:07
@matkoniecz
Copy link
Contributor

Thanks for figuring it out and submitting PR!

@matkoniecz
Copy link
Contributor

It appears that it also closes #4189

@pnorman pnorman merged commit 3618861 into gravitystorm:master Feb 10, 2021
@ZeLonewolf ZeLonewolf deleted the windows-line-ending-fix branch February 10, 2021 17:55
@jeisenbe
Copy link
Collaborator

@ZeLonewolf thank you for this PR, it was quite helpful.
If you are interested in contributing futher, we have a list of good first issues and also some more difficult issues where help is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get-external-data.py fails to run on Windows
4 participants