-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render volcanoes with a distinct icon from peaks #4331
Conversation
Thank you for working on this, @ZeLonewolf. I agree that this is an important change. The initial rendering looks pretty good. Since the tag natural=volcano is for a volcanic vent, which is not always at the top of a mountain but often in a low crater or fissure, could we try an icon that is slightly more crater-like and less peak-like? I also think the “smoke” / ash cloud could be adjusted, though I can’t quite say how. Perhaps thinner, more like the whisp of smoke on the man_made=chimney icon? |
Were you thinking something more like this? I was actually thinking we wanted something closer in shape to a spatter cone or stratovolcano, vice a more geologically accurate pit crater, since it's a more stereotypically recognizable volcano shape. That's what I tried to make before I gave up and dropped in @imagico's icon, but I could be convinced either way. |
Good idea to move forward with this. When i implemented a similar change in the ac-style (99e5738) i chose to
https://www.openstreetmap.org/#map=12/28.9590/-13.6977 |
Here are some sample renderings at z10-13 using small icons at z10 and regular icons below that. I've also switched the volcanoes to use the same color as the regular peaks. I'm not really a fan of losing the red color as it's visually a lot more difficult to see the difference now. What do people think of this approach? |
|
Volcano and peak will now show at 50% width at zoom 10. Combined peak/volcano section to take advantage of common styling.
Like in case of #4317 (comment) also here a few cartographic design principles we tend to follow here this change has issues with:
To me your tests seem to confirm that the approach taken (a pictorial point symbol to visualize volcanoes) does only work well in this style when you start the symbol significantly later than the abstract symbol for peaks - probably no earlier than z13. But i would be happy to be proven wrong about this. Also keep in mind that the whole point of the exercise is to solve #1790 and not render volcanoes any more in a way that implies they are a subtype of peaks. I am not sure if your current proposal really accomplishes that. It removes the additional color used for volcanoes (which is a good thing) but otherwise by rendering a symbol which clearly looks like a derivative of the peak symbol in exactly the same fashion to me still communicates this being a subtype of the same feature class. |
What I think I'm hearing is that we want to:
Would that be satisfactory? |
I don't think that would be a good idea. As written in #1790 what is non-satisfying right now is that we render natural=volcano in a way that implies it is a type of peak. It would be good to change that in a way that would communicate to the map user that it is not and at the same time it would be good to avoid using a color for the symbol that is very similar to the healthcare color. If you'd render peaks and volcanoes identically at lower zoom levels that would communicate the opposite and reinforce the current conflation so i don't think that would be desirable. My idea - which i showed in 99e5738 - was to show only peaks with the abstract triangle symbol starting at z11 and show volcanoes with a normal pictorial symbols starting later (at z13). I encourage you to explore other options though and hope that the design principles i sketched might help a bit with that. |
Can you clarify what you mean by the "abstract triangle symbol"? Since it's in vector form, why would you need a separate image for the small version vice just shrinking it in CSS? |
The peak symbol is a simple triangle and is recognizable as such quite easily. The volcano symbol OTOH is a pictorial symbol, it requires recognition of the specific and more complex shape and its meaning to be readable. You don't absolutely need a separate symbol design for different scales in all cases but usually, especially if as recommended the scale difference is something other than a power of two, the best readability calls for varying the symbol depending on the scale it is to be rendered at. When the symbol is rendered larger, details help recognition of the shape for what it is meant to depict while if it is shown smaller that additional detail will lead to blurriness and more difficult readability. |
Okay, (try again) so what I think I'm hearing is:
Perhaps the volcano icon could follow a concept of "smoke rising from the ground"? |
I like the many birds in this rendering :-) |
Well. I can't unsee that now. Back to the drawing board. |
Unless I'm misreading @imagico's comments above, it sounded like there was an objection to iconography that indicated that volcanoes were a subtype of peak. |
I believe that comment was in response to your plan to "Start the rendering of peaks/volcanoes at zoom 10, with the triangle peak symbol”, not in response to the new volcano icon. |
The peak symbol is eight pixels in size so working out something suitable in the standard 14 pixel symbol size should typically allow an impression sufficiently different from the peak symbol to make clear it is a fundamentally different type of feature. I don't think the pit style design you showed is intuitively readable but that is in principle the kind of experiment i wanted to encourage. The question is ultimately what does most clearly say 'volcano' that can work in a 14 pixel symbol. The cratered mountain with cloud design you showed earlier in principle seems to work though it could probably be a bit more distinct from peaks in the base shape and it also appears to be a bit blurry as is. See the ac-style version for comparison here: |
Ah, I was working off the volcano icon file to start from so it sounds like I'm using the wrong size. 14 pixels is considerably more breathing room. Is there a style guide somewhere that I should be looking at? |
Below rendering is with a 14px version of the volcano with smoke icon. This seems to be the preference. I have the volcanoes starting to render at zoom=13. Also, if anyone has any tips for the best way to generate these screen shots, I'd appreciated it. Are you using the export function in kosmtik or just taking screen shots? |
I think i am probably not the best person to make a neutral assessment here having worked on the very same problem before and in doing that having already formed an opinion on the matter. So i would encourage others to chime in here with comments on the specifics of the symbol design. Regarding sample rendering productions - the most common method is screenshots, the export function makes it too easy to produce wrong scale rendering in my experience. |
Hi, jumping in here, because of the recent eruption in Iceland. I prefer having the red color personally, because it would help users differentiate normal peak and dangerous area (volcano). I love your flat peak with a bit of smoke. |
As said above in #4331 (comment) someone else should review this (both maintainer and non-maintainer reviews welcome) since i am a bit biased here having addressed this problem in a different fashion elsewhere. |
Updated with changes requested. However, due to the issues noted at #4381 (comment), I am not able to run this PR. I temporarily removed the golf code in order to generate these render samples. |
Closing so other contributors can work on this. |
Fixes #1790
Changes proposed in this pull request:
Adds a new icon for volcanoes (
natural=volcano
), to make them distinct from thenatural=peak
icon.Test rendering with links to the example place:
Location: https://www.openstreetmap.org/#map=13/19.3878/-155.2169
Before:
After: