Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue with GPASC and GPNF. #702

Closed
wants to merge 2 commits into from
Closed

Conversation

veryspry
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2318327951/52962?folderId=6987275

Summary

Because this snippet loads the form markup via AJAX and then manually calls gform_post_render AFTER the request has succeeded. As such, some perk scripts need to wait to init until gform_post_render occurs.

…pts would run before this snippet finished loading the form into the DOM.
…efined when wrapping in `gform_post_render`.
@github-actions
Copy link

Fails
🚫

Pull request title does match the correct format. The Pull Request title should match our Snippet Library Pull Request Title Guidelines in Notion.

🚫

Commit message ' gw-cache-buster.php: Fixed issue where $script was sometimes undefined when wrapping in gform_post_render.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 71bb1f8

@veryspry
Copy link
Contributor Author

veryspry commented Sep 7, 2023

Closing as we found a better solution for this!

@veryspry veryspry closed this Sep 7, 2023
@veryspry veryspry deleted the matt/gwcb-fix-2 branch March 21, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant