Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue where zero-dollar products that had none-zero-dollar options were removed. #731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed issue where zero-dollar products that had none-zero-dollar options were removed. #731

wants to merge 1 commit into from

Conversation

spivurno
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2408973399/56781/

Summary

Updated snippet to prevent the removal of $0 products that contained non-$0 options.

No Snippet

CleanShot 2023-11-17 at 17 13 57@2x

Old Snippet

All products removed. 😆

New Snippet

CleanShot 2023-11-17 at 17 12 38@2x

@github-actions GitHub Actions
Copy link

Fails
🚫

Pull request title does match the correct format. The Pull Request title should match our Snippet Library Pull Request Title Guidelines in Notion.
🚫

Commit message 'Fixed issue where zero-dollar products that had none-zero-dollar options were removed.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.
Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against ea3c155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spivurno