Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gw-all-fields-template.php: Fixed an issue with the email field not processed as a text but a link. #732

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2429986137/57820?folderId=3808239

Summary

All Fields Template. Email fields are getting output as links. It should be getting output as an email text.

BEFORE:
Screenshot 2023-11-24 at 3 55 51 PM

AFTER:
Screenshot 2023-11-24 at 3 55 33 PM

@saifsultanc
Copy link
Contributor Author

I have one concern with this update though, if we are using that same filter value @{Nested Form:1:index[0],filter[3]} on an HTML field (for instance), before this update it was getting output as follows:
Screenshot 2023-11-24 at 3 56 27 PM
Which looks right in the link form.

However, now it is output as follows (plain text)
Screenshot 2023-11-24 at 3 57 46 PM

Perhaps, in this case, it would make sense to have it as an HTML and not plain text. But then, flipside of this argument is that the user can very well add the <a href on their field pointing to the value returned by the filter @{Nested Form:1:index[0],filter[3]}

@claygriffiths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant