gw-all-fields-template.php: Fixed a fatal error with the snippet and Nested Forms.
#751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claygriffiths
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
LGTM. Amend this last commit and increment the version here before merging: https://github.com/gravitywiz/snippet-library/blob/21ccea5cca0c94a6030d26566740dbc168a522f1/gravity-forms/gw-all-fields-template.php#L11C1-L11C1
|
@claygriffiths Ready to merge it. But the PHPCS issue pointing to a file that hasn't been touched on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2460908266/59240?folderId=3808239
Summary
The All Fields Template is causing a fatal error:
Warning: Undefined variable $input_ids in /.../gw-all-fields-template/gw-all-fields-template.php on line 201The issue is down to the
$input_idsonly getting initialized in the preceding else block (and not the if). This leads to potential scenarios of tapping in on that value/variable even though it does not exist.BEFORE:
AFTER:
