gw-cache-buster.php: Fixed issue with Cache Buster not clearing cookies with Paypal checkout and Nested entry.

[saifsultanc]

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2630007391/67768/

Summary

When Cache Buster is enabled, Nested Form fields are not being cleared when paying for a form using PayPal.

Loom demonstrating the issue: https://www.loom.com/share/4816b6c7728a416083cfc706b28ff54a?sid=540ba7fe-133d-4e13-b4fb-b00912b4a181

When we submit form with Stripe checkout, GPNF_Session::get_session_path gets the correct session path, however, the same on paypal isn't true. It gets an empty session path. GPNF_Session::delete_cookie(L180) relies on getting correct cookie to delete it. Since, the session path isn't correct with paypal it fails. This only happens with Cache Buster.

xDebug snapshot with Stripe:

xDebug snapshot with Paypal:

The fix proposed here is to ensure we have removed all cookies for that form in cache buster scenario.

[claygriffiths]

This would nuke cookies for GPNF every time you load a form that is being cached-busted.

Can you do a Git bisect on GPNF to narrow down what the cause is if it used to work?

[saifsultanc]

This would nuke cookies for GPNF every time you load a form that is being cached-busted.

Can you do a Git bisect on GPNF to narrow down what the cause is if it used to work?

The cause is this commit: https://github.com/gravitywiz/gp-nested-forms/commit/89f3f8ec54618ea8f163e5d07cd6d9a5e25d37be

where we added get_session_path in the GPNF Session implementation. It used to work normally before this version

So Cache Buster with this form setup worked fine till GPNF 1.1.34, and broke with v1.1.35.

@claygriffiths

[spivurno]

Looks good!

Approved as is but if you're feeling inspired, it'd be great to to pull the array of query args out of the function so that we only add gpnf_context property if class_exists( 'GPNF_Session' ) rather than setting it every time only setting the path it it exists.

[github-actions]

	Warnings
⚠️	When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 600238d