Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpaa-allow-browser-autocomplete.js: Added snippet to allow browser autocomplete with GPAA. #856

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2642022306/68309

Summary

Filter whether browser autocomplete should be prevented, defaults to true. This provided an easy override to false (i.e. allow browser autocomplete).

Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This arguably leans toward hook usage/example such as what's in https://gravitywiz.com/documentation/gpaa_prevent_browser_autocomplete/#examples.

I'm going to get @spivurno's take on this.

gp-address-autocomplete/gpaa-allow-browser-autocomplete.js Outdated Show resolved Hide resolved
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S&M when header is updated per suggestion

Copy link

github-actions bot commented Jul 9, 2024

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 10cc201

@saifsultanc saifsultanc merged commit 7f81b0e into master Jul 9, 2024
3 checks passed
@saifsultanc saifsultanc deleted the saif/add/68309-allow-browser-autocomplete-gpaa branch July 9, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants