Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpaa-acf-gfur-google-maps.php: Added a snippet for mapping GPAA address field to ACF map field via GF User Registration add-on. #857

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

barthc
Copy link
Contributor

@barthc barthc commented Jul 12, 2024

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2648540141/68609

Summary

A snippet for mapping GPPA address field to ACF map field via GF User Registration add-on.

Copy link

github-actions bot commented Jul 12, 2024

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 6c39e7a

@barthc barthc force-pushed the barth/add/68609-gpaa-acf-gfur-google-maps branch from 2ca5ac4 to 858f18b Compare July 12, 2024 12:52
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending suggestions


}

function gw_get_meta_field_id_by_meta_key( $feed, $field_name, $meta_key ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While unlikely for a conflict, this still seems like it needs more explicitly prefixed.

Suggested change
function gw_get_meta_field_id_by_meta_key( $feed, $field_name, $meta_key ) {
function gpaa_acf_gfur_get_meta_field_id_by_meta_key( $feed, $field_name, $meta_key ) {

add_action( 'gform_user_updated', 'update_user_acf_map_field', 10, 3 );
add_action( 'gform_user_registered', 'update_user_acf_map_field', 10, 3 );

function update_user_acf_map_field( $user_id, $feed, $entry ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefix this one as well like I suggested on the other

@@ -0,0 +1,57 @@
<?php
/**
* Gravity Perks // Address Autocomplete + ACF // Populate Google Maps Custom Field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of our hosted snippet library scraper being able to match plugins...

Suggested change
* Gravity Perks // Address Autocomplete + ACF // Populate Google Maps Custom Field
* Gravity Perks // Address Autocomplete // Populate ACF Google Maps Fields

…ddress field to `ACF` map field via GF User Registration add-on.
@barthc barthc force-pushed the barth/add/68609-gpaa-acf-gfur-google-maps branch from 858f18b to 6c39e7a Compare July 12, 2024 19:31
@barthc barthc merged commit 0d926b2 into master Jul 12, 2024
3 checks passed
@barthc barthc deleted the barth/add/68609-gpaa-acf-gfur-google-maps branch July 12, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants