gw-dynamic-range.php: Fixed issue with decimal values on dynamic range.
#858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2649614006/68685
Summary
The Dynamic range snippet doesn't work on the front end, for the max value when a decimal is entered. The issue is because on the javascript we are typecasting the current value to integer:
currentValue = parseInt( currentValue );. Overriding that fixes the issue.BEFORE:
https://www.loom.com/share/c002e98098374e09b65e8782744c2062
AFTER: (~30 seconds)
https://www.loom.com/share/643a79c35fbc4c6986835a9e9dc52831