gpnf-copy-parent-value-manually.js: Fixed an issue where source field value is not copied over if it is a dropdown or radio button field.
#873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld value is not copied over if it is a dropdown or radio button field.
claygriffiths
approved these changes
Aug 26, 2024
Comment on lines
+28
to
+30
| var value = jQuery ( '#input_{0}_{1}'.gformFormat( parentFormId, parentFieldId ) ).val() || | ||
| jQuery('input[name="input_{0}"]:checked'.gformFormat( parentFieldId )).val() || | ||
| jQuery('input[name="input_{0}"]:selected'.gformFormat( parentFieldId )).val(); |
There was a problem hiding this comment.
Just stating this for posterity, this whole copyParentFormValue is very basic and by the looks of it, would likely only work for copying a single value into a text/textarea input. I'm not sure how complicated we want to make this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2670546355/69628
Summary
The
gpnf-copy-parent-value-manually.jssnippet doesn't work when the parent form source field is a Radio button field.This PR would fix the issue.