Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gw-fuzzy-match.php: Added snippet for fuzzy comparison. #875

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2684279710/70182?

Summary

Fuzzy logic comparison for "is" operator.

Demo:
https://www.loom.com/share/a00c9279ca3d4958b1d08004951beffb

@spivurno
Copy link
Contributor

@saifsultanc Haven't tested functionality but saw that this was submitted as two separate files. As a general rule, let's avoid this if we can in favor of our PHP/JS snippet template. It's so much easier for our customers to understand and install and keeps all future changes in a single file. 🙏

@saifsultanc
Copy link
Contributor Author

@saifsultanc Haven't tested functionality but saw that this was submitted as two separate files. As a general rule, let's avoid this if we can in favor of our PHP/JS snippet template. It's so much easier for our customers to understand and install and keeps all future changes in a single file. 🙏

Noted. Will sort this out Monday.

@saifsultanc
Copy link
Contributor Author

Updated!

Copy link
Contributor

@spivurno spivurno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @saifsultanc!

Feedback below all to do with positioning this as a GF snippet rather than a GPCP snippet.

gp-conditional-pricing/gpcp-fuzzy-comparison.php Outdated Show resolved Hide resolved
gp-conditional-pricing/gpcp-fuzzy-comparison.php Outdated Show resolved Hide resolved
gp-conditional-pricing/gpcp-fuzzy-comparison.php Outdated Show resolved Hide resolved
gp-conditional-pricing/gpcp-fuzzy-comparison.php Outdated Show resolved Hide resolved
@saifsultanc saifsultanc changed the title gpcp-fuzzy-comparison.php: Added snippet for fuzzy comparison. gw-fuzzy-comparison.php: Added snippet for fuzzy comparison. Aug 28, 2024
@saifsultanc saifsultanc changed the title gw-fuzzy-comparison.php: Added snippet for fuzzy comparison. gw-fuzzy-match.php: Added snippet for fuzzy comparison. Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

Messages
📖 Merlin would give this scroll the highest of praises. Cheers for adding this new snippet to the library! 🪄

Generated by 🚫 dangerJS against cb428e9

@saifsultanc
Copy link
Contributor Author

@spivurno Updated all points. Lmk what you think about this now!

Copy link
Contributor

@spivurno spivurno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saifsultanc Left some minor copy edits inline. Review, merge, and we're golden. 🙌

gravity-forms/gw-fuzzy-comparison.php Outdated Show resolved Hide resolved
gravity-forms/gw-fuzzy-comparison.php Outdated Show resolved Hide resolved
gravity-forms/gw-fuzzy-comparison.php Outdated Show resolved Hide resolved
@saifsultanc saifsultanc merged commit b77621a into master Aug 28, 2024
3 checks passed
@saifsultanc saifsultanc deleted the saif/add/70182-gpcp-fuzzy-comparison branch August 28, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants