Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gw-require-unique-values.php: Fixed issue with Product Value comparison. #876

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2686989633/70358

Summary

The snippet doesn't work when the fields involved are Product Choice fields having similar label/value property but different prices.

@saifsultanc saifsultanc added the bug Something isn't working label Aug 23, 2024
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick suggestion—this is how I see GF doing this check.

gravity-forms/gw-require-unique-values.php Outdated Show resolved Hide resolved
Copy link

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 72f0486

Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, S&M

@saifsultanc saifsultanc merged commit 5c9778b into master Aug 28, 2024
3 checks passed
@saifsultanc saifsultanc deleted the saif/fix/70358-fix-product-value-comparison branch August 28, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants