ci: Upload PDF on release, not tag #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An example run: https://github.com/michael-wisely-gravwell/training/actions/runs/10705579330 The attachment on the release: https://github.com/michael-wisely-gravwell/training/releases/tag/v1.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses no issue.
I'd written the Release workflow to automatically create a Release AND upload a build PDF to that release when a tag was created.
That does a little too much. It would be more useful to just build the PDF and attach it to the Release once it's published (pre-release or full release, as long as it's non-draft we'll build and attach a PDF).
This PR proposes modifying
release.ymlto...