Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pretty_* functions that should not be included until 5.5.0 #1009

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ashnwade
Copy link
Collaborator

@ashnwade ashnwade commented Jun 4, 2024

This PR addresses no issue, but it came to my attention because #1007 was submitted. I was looking to see if the duplicate pretty_count should just be removed or if it was a copy/paste error that was intended to be edited into some other pretty_* function. It looks like all of the pretty_* functions were documented, but it got published too soon.

@ashnwade
Copy link
Collaborator Author

ashnwade commented Jun 4, 2024

@david-fritz-gravwell PTAL

Copy link
Contributor

@david-fritz-gravwell david-fritz-gravwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-fritz-gravwell david-fritz-gravwell merged commit 6f4d062 into gravwell:master Jun 4, 2024
@ashnwade ashnwade deleted the pretty-count branch July 12, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants