Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ageout wording #1130

Merged
merged 12 commits into from
Oct 2, 2024
Merged

Conversation

kris-watts-gravwell
Copy link
Contributor

This PR addresses no issue, just tweaking some wording on ageout rules for clarity.

@kris-watts-gravwell
Copy link
Contributor Author

ignore the high number of commits, I branched off of my dev branch and did an upstream checkout on a file so that this PR was clean on the specific thing I was doing.

@ashnwade ashnwade changed the base branch from dev to next-patch October 2, 2024 19:09
@ashnwade ashnwade dismissed john-floren-gravwell’s stale review October 2, 2024 19:09

The base branch was changed.

Copy link
Collaborator

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits

configuration/ageout.md Outdated Show resolved Hide resolved
configuration/ageout.md Outdated Show resolved Hide resolved
john-floren-gravwell and others added 2 commits October 2, 2024 12:11
Co-authored-by: Ashley Wade <107071905+ashnwade@users.noreply.github.com>
Co-authored-by: Ashley Wade <107071905+ashnwade@users.noreply.github.com>
Copy link
Collaborator

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnwade ashnwade merged commit 000e297 into gravwell:next-patch Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants