Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document else if style statements. #1132

Merged
merged 1 commit into from
Oct 2, 2024
Merged

document else if style statements. #1132

merged 1 commit into from
Oct 2, 2024

Conversation

david-fritz-gravwell
Copy link
Contributor

Fixes #1124

ashnwade
ashnwade approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashnwade
ashnwade requested changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you put else if here, but we use "if" and "else" up above. We should probably be more consistent on using either quotes or backticks.

@david-fritz-gravwell
Copy link
Contributor Author

That's intentional as the syntax we're calling out is specifically else if.

ashnwade
ashnwade approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnwade ashnwade merged commit 47aab68 into gravwell:next-minor Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashnwade ashnwade ashnwade approved these changes

@kris-watts-gravwell kris-watts-gravwell Awaiting requested review from kris-watts-gravwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-fritz-gravwell @ashnwade