Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on partial downloads. #1226

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

david-fritz-gravwell
Copy link
Contributor

Fixes #1216

Copy link
Collaborator

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions because partial results can be for sharing and saving results too, not just downloading.

Also, do we need some additional details about why this differs from the overview chart? "regardless of what the overview chart indicates" makes me feel like the overview chart should be disregarded or untrusted...?

admin/limits.md Outdated Show resolved Hide resolved
admin/limits.md Outdated Show resolved Hide resolved
david-fritz-gravwell and others added 2 commits October 29, 2024 10:07
Co-authored-by: Ashley Wade <107071905+ashnwade@users.noreply.github.com>
Co-authored-by: Ashley Wade <107071905+ashnwade@users.noreply.github.com>
@david-fritz-gravwell
Copy link
Contributor Author

Some minor suggestions because partial results can be for sharing and saving results too, not just downloading.

Also, do we need some additional details about why this differs from the overview chart? "regardless of what the overview chart indicates" makes me feel like the overview chart should be disregarded or untrusted...?

The overview chart shows all the stats and we don't indicate where the actual stored data stops, so for the purposes of downloading, saving, etc., we can't use the overview chart as any reference.

@david-fritz-gravwell
Copy link
Contributor Author

@ashnwade PTAL

Copy link
Collaborator

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnwade ashnwade merged commit 900f45e into gravwell:next-patch Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants