-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note on partial downloads. #1226
Add note on partial downloads. #1226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions because partial results can be for sharing and saving results too, not just downloading.
Also, do we need some additional details about why this differs from the overview chart? "regardless of what the overview chart indicates" makes me feel like the overview chart should be disregarded or untrusted...?
Co-authored-by: Ashley Wade <107071905+ashnwade@users.noreply.github.com>
Co-authored-by: Ashley Wade <107071905+ashnwade@users.noreply.github.com>
The overview chart shows all the stats and we don't indicate where the actual stored data stops, so for the purposes of downloading, saving, etc., we can't use the overview chart as any reference. |
@ashnwade PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1216