Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add note about timestamp truncation. Remove erroneous statement about compound queries. #1304

Merged
merged 4 commits into from
Dec 16, 2024
Merged

add note about timestamp truncation. Remove erroneous statement about compound queries. #1304

merged 4 commits into from
Dec 16, 2024

Conversation

david-fritz-gravwell
Copy link
Contributor

Fixes #1296

@ashnwade ashnwade added this to the next-patch milestone Dec 16, 2024
ashnwade
ashnwade requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I have another question:
"closest second" makes it sound like rounding. 3.9 - > 4
but "truncate" makes me think that we just drop the subsecond precision. 3.9 -> 3

I guess I am still not sure what is actually happening?

ashnwade
ashnwade approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnwade ashnwade merged commit fa098d9 into gravwell:next-patch Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashnwade ashnwade ashnwade approved these changes

Assignees

@david-fritz-gravwell david-fritz-gravwell

Labels
None yet
Projects
None yet
Milestone
next-patch
Development

Successfully merging this pull request may close these issues.
2 participants
@david-fritz-gravwell @ashnwade