Make replication storage limit considerations more clear. #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnwade
requested changes
Dec 16, 2024
There was a problem hiding this comment.
This description looks good to me. But I went and looked at Max-Replicated-Data-GB here:
https://docs.gravwell.io/configuration/parameters.html#max-replicated-data-gb
The description for the configuration says " it will first remove any shards which have been deleted on the original indexer, then it will begin deleting the oldest shards." It does not mention cold shards in between deleted and old. I think we should probably revise the configuration page to make these descriptions consistent.
ashnwade
reviewed
Dec 16, 2024
Co-authored-by: Ashley Wade <107071905+ashnwade@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1222