chore: Upgrade packages + Migrate to Boostrap 5 #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-wisely-gravwell
changed the title
ashnwade
previously requested changes
Jan 9, 2024
ashnwade
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't address any particular issue, but it's related to #838
This PR proposes bumping the version of nixpkgs that we're pulling, effectively upgrading all relevant packages.
As a result of the pkgs bump, we're using pydata-sphinx-theme@0.15.1 which uses Bootstrap 5. Boostrap 5 has some backward-incompatible changes, so this PR also proposes updating relevant source files to use Bootstrap 5 stuff.
Unfortunately, pydata-sphinx-theme@0.15.1 doesn't appear to make the
bootstrapglobal available. Out of the box, one can't enable Popovers in the way the Boostrap docs recommend. I forked the theme, added a line to the bundled bootstrap.js file, built the theme into a Python wheel, and included it in this repo. By vendorizing the lib, I was able to pull in the change to makebootstrapglobally available.In summary, this PR proposes...