Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #895

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Update README #895

merged 2 commits into from
Jan 23, 2024

Conversation

michael-wisely-gravwell
Copy link
Contributor

This PR is related to #838

This PR proposes an update to the README, explaining how deployment works with the new version switcher changes.

README.md Outdated
├─ 404.html
├─ index.html
├─ ...
├─ v5.4.4 <- the full build of v5.4.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this have / after v5.4.4 to indicate a directory (like docs/ above)?

README.md Outdated
│ ├─ 404.html
│ ├─ index.html
│ ├─ ...
├─ v5.4.3 <- the full build of v5.4.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this have / after v5.4.3 to indicate a directory (like docs/ above)?

README.md Outdated
2. Rename `docs/` to `vN.N.N+1` (or whatever version it is)
3. Add the docs for the new version in `docs/`
- Don't forget to update `_static/versions.json`!
4. Move all `v.N.N.N` and `vN.N.N+1` back into `docs/`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could maybe use a little more clarification.

  1. Do you want to Copy (meaning the original stays where it is)?
    so that in...

  2. the docs/ directory that we rename still has all the previous versions in it also?

  3. There is no docs/ directory after it was renamed in 2, so I don't know if we want to simply say Add the docs to that location. Probably obvious enough, but I don't think the language is precise.

  4. I had to read this more than once. I get it, but maybe there is an easier way to explain?

I thought your tree outline above clearly demonstrates the desired outcome though, so I am able to reason through the intent here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these steps are overkill. There's more than one way to accomplish the task.

In the end, all that matters is the directory structure, which is outlined.

README.md Outdated

```
docs/
├─ latest/ <- a link to v5.4.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure you have tested this and it works, but does latest here need any further explanation since latest isn't in the URL and isn't mentioned in the first tree outline?

README.md Outdated

As implied by the path, only the `versions.json` that's included in the latest docs version needs to be up-to-date. It doesn't matter if any `.../vN.N.N/_static/versions.json` is out of date. Only the file at `/_static/verions.json` is used.

The [PyData Sphinx Theme docs](https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/version-dropdown.html#add-a-json-file-to-define-your-switcher-s-versions) explain the optins in more detail, but here's a quick summary / example:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The [PyData Sphinx Theme docs](https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/version-dropdown.html#add-a-json-file-to-define-your-switcher-s-versions) explain the optins in more detail, but here's a quick summary / example:
The [PyData Sphinx Theme docs](https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/version-dropdown.html#add-a-json-file-to-define-your-switcher-s-versions) explain the options in more detail, but here's a quick summary / example:

Copy link
Collaborator

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnwade ashnwade merged commit cbfcf52 into gravwell:dev Jan 23, 2024
@michael-wisely-gravwell michael-wisely-gravwell deleted the update-readme branch January 26, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants