Skip to content

Commit

Permalink
feat(design): change daffManageContainerLayoutMixin to a directive
Browse files Browse the repository at this point in the history
  • Loading branch information
xelaint authored and damienwebdev committed Jul 30, 2024
1 parent b00d1e1 commit c2111b3
Show file tree
Hide file tree
Showing 8 changed files with 93 additions and 74 deletions.
11 changes: 6 additions & 5 deletions libs/design/callout/src/callout/callout.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
daffColorMixin,
DaffCompactable,
daffCompactableMixin,
daffManageContainerLayoutMixin,
DaffManageContainerLayoutDirective,
DaffTextAlignable,
daffTextAlignmentMixin,
} from '@daffodil/design';
Expand All @@ -25,7 +25,7 @@ class DaffCalloutBase {
constructor(public _elementRef: ElementRef, public _renderer: Renderer2) {}
}

const _daffCalloutBase = daffManageContainerLayoutMixin(daffColorMixin(daffCompactableMixin(daffTextAlignmentMixin(DaffCalloutBase, 'left'))));
const _daffCalloutBase = daffColorMixin(daffCompactableMixin(daffTextAlignmentMixin(DaffCalloutBase, 'left')));

/**
* @inheritdoc
Expand All @@ -38,9 +38,10 @@ const _daffCalloutBase = daffManageContainerLayoutMixin(daffColorMixin(daffCompa
//todo(damienwebdev): remove once decorators hit stage 3 - https://github.com/microsoft/TypeScript/issues/7342
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: ['color', 'compact', 'textAlignment'],
hostDirectives: [{
directive: DaffArticleEncapsulatedDirective,
}],
hostDirectives: [
{ directive: DaffArticleEncapsulatedDirective },
{ directive: DaffManageContainerLayoutDirective },
],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class DaffCalloutComponent extends _daffCalloutBase implements DaffColorable, DaffTextAlignable, DaffCompactable {
Expand Down
11 changes: 6 additions & 5 deletions libs/design/hero/src/hero/hero.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
daffColorMixin,
DaffCompactable,
daffCompactableMixin,
daffManageContainerLayoutMixin,
DaffManageContainerLayoutDirective,
DaffTextAlignable,
daffTextAlignmentMixin,
} from '@daffodil/design';
Expand All @@ -25,7 +25,7 @@ class DaffHeroBase {
constructor(public _elementRef: ElementRef, public _renderer: Renderer2) {}
}

const _daffHeroBase = daffManageContainerLayoutMixin(daffColorMixin(daffCompactableMixin(daffTextAlignmentMixin(DaffHeroBase, 'left'))));
const _daffHeroBase = daffColorMixin(daffCompactableMixin(daffTextAlignmentMixin(DaffHeroBase, 'left')));

/**
* @inheritdoc
Expand All @@ -38,9 +38,10 @@ const _daffHeroBase = daffManageContainerLayoutMixin(daffColorMixin(daffCompacta
//todo(damienwebdev): remove once decorators hit stage 3 - https://github.com/microsoft/TypeScript/issues/7342
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: ['color', 'compact', 'textAlignment'],
hostDirectives: [{
directive: DaffArticleEncapsulatedDirective,
}],
hostDirectives: [
{ directive: DaffArticleEncapsulatedDirective },
{ directive: DaffManageContainerLayoutDirective },
],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class DaffHeroComponent extends _daffHeroBase implements DaffColorable, DaffTextAlignable, DaffCompactable {
Expand Down
7 changes: 5 additions & 2 deletions libs/design/navbar/src/navbar/navbar.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import {

import {
DaffColorable,
DaffManageContainerLayoutDirective,
daffColorMixin,
daffManageContainerLayoutMixin,
} from '@daffodil/design';

/**
Expand All @@ -20,7 +20,7 @@ class DaffNavbarBase {
constructor(public _elementRef: ElementRef, public _renderer: Renderer2) {}
}

const _daffNavbarBase = daffManageContainerLayoutMixin(daffColorMixin(DaffNavbarBase));
const _daffNavbarBase = daffColorMixin(DaffNavbarBase);

/**
* @inheritdoc
Expand All @@ -33,6 +33,9 @@ const _daffNavbarBase = daffManageContainerLayoutMixin(daffColorMixin(DaffNavbar
//todo(damienwebdev): remove once decorators hit stage 3 - https://github.com/microsoft/TypeScript/issues/7342
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: ['color'],
hostDirectives: [{
directive: DaffManageContainerLayoutDirective,
}],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class DaffNavbarComponent extends _daffNavbarBase implements DaffColorable {
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
import {
Component,
DebugElement,
} from '@angular/core';
import {
waitForAsync,
ComponentFixture,
TestBed,
} from '@angular/core/testing';
import { By } from '@angular/platform-browser';

import { DaffManageContainerLayoutDirective } from './manage-container-layout.directive';

@Component({
template: `
<div daffManageContainerLayout></div>`,
})

class WrapperComponent {}

describe('@daffodil/design | DaffManageContainerLayoutDirective', () => {
let wrapper: WrapperComponent;
let de: DebugElement;
let fixture: ComponentFixture<WrapperComponent>;
let directive: DaffManageContainerLayoutDirective;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
declarations: [
WrapperComponent,
],
imports: [
DaffManageContainerLayoutDirective,
],
})
.compileComponents();
}));

beforeEach(() => {
fixture = TestBed.createComponent(WrapperComponent);
wrapper = fixture.componentInstance;
de = fixture.debugElement.query(By.css('[daffManageContainerLayout]'));
directive = de.injector.get(DaffManageContainerLayoutDirective);
fixture.detectChanges();
});

it('should create', () => {
expect(wrapper).toBeTruthy();
expect(directive).toBeTruthy();
});

it('should add a class of "daff-manage-container-layout" to the host element', () => {
expect(de.classes).toEqual(jasmine.objectContaining({
'daff-manage-container-layout': true,
}));
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import {
Directive,
HostBinding,
} from '@angular/core';

/**
* A directive that gives a component the ability to manage a DaffContainerComponent's layout.
* It passes predetermined layout styles down to the container. In order for a component to
* do this, it must includes this directive as a hostDirective.
*/
@Directive({
selector: '[daffManageContainerLayout]',
standalone: true,
})

export class DaffManageContainerLayoutDirective {
@HostBinding('class.daff-manage-container-layout') class = true;
}

This file was deleted.

2 changes: 1 addition & 1 deletion libs/design/src/core/manage-container-layout/public_api.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { daffManageContainerLayoutMixin } from './manage-container-layout-mixin';
export { DaffManageContainerLayoutDirective } from './manage-container-layout.directive';

0 comments on commit c2111b3

Please sign in to comment.