-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design): create DaffOpenableDirective
#2908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xelaint
added
package: design
@daffodil/design
status: awaiting review
This PR is awaiting review
labels
Jul 12, 2024
xelaint
changed the title
feat(design): create DaffOpenable` interface
feat(design): create Jul 12, 2024
DaffOpenable
interface
xelaint
added
status: wip
This PR is WIP. It should be marked as a draft.
and removed
status: awaiting review
This PR is awaiting review
labels
Jul 16, 2024
xelaint
force-pushed
the
openable-interface
branch
from
July 16, 2024 17:41
439e580
to
591fb30
Compare
xelaint
added
status: awaiting review
This PR is awaiting review
and removed
status: wip
This PR is WIP. It should be marked as a draft.
labels
Jul 16, 2024
@damienwebdev Need to finalize what the output naming is for the openable directive. Are we sticking to |
xelaint
force-pushed
the
openable-interface
branch
from
July 23, 2024 15:04
591fb30
to
3332f41
Compare
xelaint
changed the title
feat(design): create
feat(design): create Jul 24, 2024
DaffOpenable
interfaceDaffOpenableDirective
damienwebdev
requested changes
Jul 29, 2024
xelaint
force-pushed
the
openable-interface
branch
from
August 12, 2024 13:02
3332f41
to
8a7d0b2
Compare
@griest024 we made some updates according to your concerns. lmk what you think. |
griest024
requested changes
Aug 27, 2024
griest024
requested changes
Sep 3, 2024
xelaint
force-pushed
the
openable-interface
branch
from
September 17, 2024 16:21
c40a896
to
1663b2b
Compare
griest024
previously approved these changes
Sep 24, 2024
xelaint
force-pushed
the
openable-interface
branch
from
September 24, 2024 18:18
52b13c0
to
6e2c2e6
Compare
xelaint
force-pushed
the
openable-interface
branch
from
September 24, 2024 18:51
6e2c2e6
to
28a0364
Compare
@griest024 had to fix some tests |
xelaint
force-pushed
the
openable-interface
branch
from
October 3, 2024 14:47
d0643b1
to
eeb520c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Part of: #763
Fixes: #3020
What is the new behavior?
Does this PR introduce a breaking change?
Other information