Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: change daffStatusMixin to a directive #2941

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jul 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

An ElementRef and Renderer need to be constructed for the daffStatusMixin to be extendable or usable in a component.

Part of: #2911

What is the new behavior?

Removed daffStatusMixin in favor of DaffStatusableDirective so that a component can use the directive by adding it as a hostDirective. This reduces code complexity.

Dependent on #2913, #2919, #2922, #2923, #2925, #2937 to be merged first.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: daffStatusMixin has been removed in favor of DaffStatusableDirective. Update usage by using the hostDirective feature.

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change status: awaiting review This PR is awaiting review labels Jul 23, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jul 23, 2024
@xelaint xelaint requested review from a team as code owners July 23, 2024 22:20
@xelaint xelaint force-pushed the status-mixin-to-directive branch from 594b7d3 to 36e2a59 Compare July 23, 2024 22:22
@xelaint xelaint force-pushed the status-mixin-to-directive branch from 36e2a59 to e05fa3e Compare July 23, 2024 22:39
@damienwebdev damienwebdev force-pushed the status-mixin-to-directive branch from e05fa3e to 87c377e Compare July 30, 2024 19:48
@damienwebdev damienwebdev force-pushed the status-mixin-to-directive branch from 87c377e to a754b4c Compare July 30, 2024 21:53
BREAKING CHANGE: daffStatusMixin has been removed in favor of DaffStatusableDirective. Update usage by using the hostDirective feature.
@damienwebdev damienwebdev force-pushed the status-mixin-to-directive branch from a754b4c to c2b68d0 Compare July 30, 2024 21:55
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 688b92d into develop Jul 30, 2024
3 of 4 checks passed
@damienwebdev damienwebdev deleted the status-mixin-to-directive branch July 30, 2024 21:55
@gray-bot gray-bot mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants