Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: change daffSizeMixin to a directive #2925

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jul 19, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

An ElementRef and Renderer need to be constructed for the daffSizeMixin to be extendable or usable in a component.

Part of: #2911

What is the new behavior?

Removed daffSizeMixin in favor of DaffSizableDirective so that a component can use the directive by adding it as a hostDirective. This reduces code complexity.

Dependent on #2913, #2919, #2922, #2923 to be merged first.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: daffSizeMixin has been removed in favor of DaffSizableDirective. Update usage by using the hostDirective feature.

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change status: awaiting review This PR is awaiting review labels Jul 19, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jul 19, 2024
@xelaint xelaint requested a review from a team as a code owner July 19, 2024 16:21
@xelaint xelaint force-pushed the size-mixin-to-directive branch from ceb32bf to 2f12240 Compare July 19, 2024 16:39
@xelaint xelaint requested review from a team as code owners July 19, 2024 16:39
@damienwebdev damienwebdev force-pushed the size-mixin-to-directive branch from 2f12240 to f9ad68c Compare July 30, 2024 17:31
@damienwebdev damienwebdev force-pushed the size-mixin-to-directive branch from f9ad68c to aa77469 Compare July 30, 2024 19:15
@damienwebdev damienwebdev merged commit aa77469 into develop Jul 30, 2024
3 of 4 checks passed
@gray-bot gray-bot mentioned this pull request Jul 30, 2024
@damienwebdev damienwebdev deleted the size-mixin-to-directive branch July 30, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants