Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(design): convert @daffodil/design components to standalone #3054

Merged
merged 18 commits into from
Sep 27, 2024
Merged

feat(design): convert @daffodil/design components to standalone #3054

merged 18 commits into from
Sep 27, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Sep 9, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Part of: #3027

What is the new behavior?

Design components have been converted to standalone. Components should still work by using the module, but deprecation notices have been added.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Sep 9, 2024
@xelaint xelaint requested review from a team as code owners September 9, 2024 20:40
@xelaint xelaint added the status: awaiting review This PR is awaiting review label Sep 10, 2024
@damienwebdev damienwebdev mentioned this pull request Sep 17, 2024
Open
@xelaint xelaint force-pushed the convert-design-to-standalone branch 2 times, most recently from 7c0da1c to 7d32653 Compare September 20, 2024 15:03
damienwebdev
damienwebdev previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is awesome!

@xelaint xelaint force-pushed the convert-design-to-standalone branch 2 times, most recently from 8240bd5 to ab825bf Compare September 27, 2024 16:11
@xelaint @damienwebdev
feat(design): convert button component to standalone (#3054)
0205e92
@xelaint @damienwebdev
feat(design): convert callout component to standalone (#3054)
1de68ab
@xelaint @damienwebdev
feat(design): convert card component to standalone (#3054)
7f830b6
@xelaint @damienwebdev
feat(design): convert container component to standalone (#3054)
994f8bb
@xelaint @damienwebdev
feat(design): convert hero to standalone (#3054)
8fd50a6
@xelaint @damienwebdev
feat(design): convert image to standalone (#3054)
19ca741
@xelaint @damienwebdev
feat(design): convert link set component to standalone (#3054)
b54d941
@xelaint @damienwebdev
feat(design): convert list component to standalone (#3054)
328a70a
@xelaint @damienwebdev
feat(desing): convert loading icon component to standalone (#3054)
708a6fa
@xelaint @damienwebdev
feat(design): convert media gallery component to standalone (#3054)
fd933cc
@xelaint @damienwebdev
feat(design): convert navbar component to standalone (#3054)
dcf8f5c
@xelaint @damienwebdev
feat(design): convert notification component to standalone (#3054)
7ca68fd
@xelaint @damienwebdev
feat(design): convert paginator component to standalone (#3054)
8caa5e1
@xelaint @damienwebdev
feat(design): convert progress bar component to standalone (#3054)
0c1fc77
@xelaint @damienwebdev
feat(design): convert sidebar component to standalone (#3054)
ce058dd
@xelaint @damienwebdev
feat(design): convert tree component to standalone (#3054)
d5cad9a
@damienwebdev damienwebdev merged commit d5cad9a into develop Sep 27, 2024
3 of 4 checks passed
@damienwebdev damienwebdev deleted the convert-design-to-standalone branch September 27, 2024 16:49
@gray-bot gray-bot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienwebdev damienwebdev damienwebdev left review comments

Assignees
No one assigned
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xelaint @damienwebdev