Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Refactor Button Component #3196

Closed
xelaint opened this issue Oct 10, 2024 · 0 comments · Fixed by #3328
Closed

[FEAT] Refactor Button Component #3196

xelaint opened this issue Oct 10, 2024 · 0 comments · Fixed by #3328
Assignees
Labels
feat a new feature, enhancement, or improvement package: design @daffodil/design
Milestone

Comments

@xelaint
Copy link
Member

xelaint commented Oct 10, 2024

💡 Feature request

Feature Name

Refactor Button Component

The Desired Behavior

Every button variant should be its own component, rather than it all being in one single component. They still share the same css class of .daff-button, with an extension of the variant name, i.e. .daff-flat-button

Your Use Case

As a developer, I would like to reduce the file size of the button component and unnecessary import of all button variants.

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design labels Oct 10, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Oct 10, 2024
@xelaint xelaint self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat a new feature, enhancement, or improvement package: design @daffodil/design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant